Re: [PATCH 1/3] Add support for command line arguments on hid2hci tool

[Marcel Holtmann <marcel@holtmann.org>]

Hi Mario,

> > please restrict the commit message to 70-72 chars per line.
> >
> > And please do the following changes:
> >
> > s/radiomode/mode/ since it is not about the radio part here.
> >
> > s/hidproxy/csr/ if you wanna expose this then call it what it is.
> >
> > And go over the coding style once more since there are some cases where
> > it breaks.
> >
> > Also please split Makefile/rules changes from the actual code changes. I
> > want two patches here. One that fixes the code and another one that
> > takes care of the udev integration.
> >
> > Other than that, looks pretty good.
> >   
> Thanks for the feedback.  I've hopefully addressed all of your
> concerns.  If you still have problems with coding style, can you please
> point them out specifically?  The attached patch is the code portion of
> the split up patch.  Again it's attached so my mail server doesn't
> mangle it.

patch has been applied. However I was serious about the 70-72 chars
width of the commit message. Had to manually fix that.

Also it is Bluetooth and not bluetooth when writing about it. That is a
trademark issue :)

Regards

Marcel