From: Torez Smith <lnxtorez@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linuxppc-dev <linuxppc-dev@ozlabs.org>
Subject: [PATCH] bug fix in arch/powerpc/mm/tlb_nohash_low.S
Date: Sun, 17 May 2009 23:49:06 -0500 [thread overview]
Message-ID: <1242622146.31702.26.camel@torez.austin.ibm.com> (raw)
File arch/powerpc/mm/tlb_nohash_low.S defines various processor specific low level TLB invalidation. Most all family of validations are grouped via pre-processor defines with the intent we error out if we reach the end and our platform is not represented. Given this, the last few lines of the file should look similar to the following....
<< SNIP >>
1: wrtee r10
blr
#else
#error Unsupported processor type !
#endif
However, the #else is incorrectly written as #elif. On some of the newer compilers/assemblers, this will not successfully assemble and will cause an error.
Signed-off-by: Torez Smith <lnxtorez@linux.vnet.ibm.com>
---
Index: linux-2.6.29/arch/powerpc/mm/tlb_nohash_low.S
===================================================================
--- linux-2.6.29.orig/arch/powerpc/mm/tlb_nohash_low.S 2009-05-17 21:31:20.000000000 -0500
+++ linux-2.6.29/arch/powerpc/mm/tlb_nohash_low.S 2009-05-17 21:31:40.000000000 -0500
@@ -161,6 +161,6 @@
isync
1: wrtee r10
blr
-#elif
+#else
#error Unsupported processor type !
#endif
--
Torez Smith
IBM Linux Technology Center
next reply other threads:[~2009-05-18 4:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 4:49 Torez Smith [this message]
2009-05-18 5:12 ` [PATCH] bug fix in arch/powerpc/mm/tlb_nohash_low.S Benjamin Herrenschmidt
2009-05-18 5:47 ` Stephen Rothwell
2009-05-18 5:52 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242622146.31702.26.camel@torez.austin.ibm.com \
--to=lnxtorez@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.