All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>
Subject: [Qemu-devel] [PATCH 0/4] Make qemu-img create options generic
Date: Mon, 18 May 2009 16:42:08 +0200	[thread overview]
Message-ID: <1242657732-29043-1-git-send-email-kwolf@redhat.com> (raw)

Currently, qemu-img and the bdrv_create() interface need to carry parameters
for every single option that is used by at least one file format. We already
have a few of such format specific options (encryption for qcow2, version 6
header for VMDK, backing file for some formats) and there are more to come
(like qcow cluster size).

This patch series changes this into a more generic approach: All block drivers
contain a data structure which describes all options this driver recognizes.
qemu-img can use this structure then instead of hard-coding every single
option. An -o option is introduced for these parameteres, the format is the
usual comma separated name=value style like in -drive.

Kevin Wolf (4):
  Create qemu-option.h
  Convert all block drivers to new bdrv_create
  Convert qemu-img create to new bdrv_create
  Convert qemu-img convert to new bdrv_create

 Makefile          |    2 +-
 block.c           |   44 +++++--
 block.h           |    6 +-
 block/cow.c       |   26 +++-
 block/qcow.c      |   28 ++++-
 block/qcow2.c     |   36 +++++-
 block/raw-posix.c |   37 ++++--
 block/raw-win32.c |   20 +++-
 block/vmdk.c      |   28 ++++-
 block/vpc.c       |   21 +++-
 block/vvfat.c     |    4 +-
 block_int.h       |   17 ++-
 qemu-img.c        |  188 ++++++++++++++++++++---------
 qemu-option.c     |  349 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 qemu-option.h     |   67 ++++++++++
 sysemu.h          |    2 -
 vl.c              |   38 +------
 17 files changed, 762 insertions(+), 151 deletions(-)
 create mode 100644 qemu-option.c
 create mode 100644 qemu-option.h

             reply	other threads:[~2009-05-18 14:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-18 14:42 Kevin Wolf [this message]
2009-05-18 14:42 ` [Qemu-devel] [PATCH 1/4] Create qemu-option.h Kevin Wolf
2009-05-18 14:42 ` [Qemu-devel] [PATCH 2/4] Convert all block drivers to new bdrv_create Kevin Wolf
2009-05-18 14:42 ` [Qemu-devel] [PATCH 3/4] Convert qemu-img create " Kevin Wolf
2009-05-18 14:42 ` [Qemu-devel] [PATCH 4/4] Convert qemu-img convert " Kevin Wolf
2009-05-18 17:05   ` Christoph Hellwig
2009-05-19  7:48     ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242657732-29043-1-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.