[Qemu-devel] [PATCH 01/13] net: factor tap_read_packet() out of tap_send()

[Mark McLoughlin <markmc@redhat.com>]

Move portability clutter out into its own function.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
---
 net.c |   28 +++++++++++++++++++---------
 1 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/net.c b/net.c
index 671138f..a819043 100644
--- a/net.c
+++ b/net.c
@@ -806,21 +806,31 @@ static void tap_receive(void *opaque, const uint8_t *buf, int size)
     }
 }
 
-static void tap_send(void *opaque)
-{
-    TAPState *s = opaque;
-    uint8_t buf[4096];
-    int size;
-
 #ifdef __sun__
+static ssize_t tap_read_packet(int tapfd, uint8_t *buf, int maxlen)
+{
     struct strbuf sbuf;
     int f = 0;
-    sbuf.maxlen = sizeof(buf);
+
+    sbuf.maxlen = maxlen;
     sbuf.buf = (char *)buf;
-    size = getmsg(s->fd, NULL, &sbuf, &f) >=0 ? sbuf.len : -1;
+
+    return getmsg(tapfd, NULL, &sbuf, &f) >= 0 ? sbuf.len : -1;
+}
 #else
-    size = read(s->fd, buf, sizeof(buf));
+static ssize_t tap_read_packet(int tapfd, uint8_t *buf, int maxlen)
+{
+    return read(tapfd, buf, maxlen);
+}
 #endif
+
+static void tap_send(void *opaque)
+{
+    TAPState *s = opaque;
+    uint8_t buf[4096];
+    int size;
+
+    size = tap_read_packet(s->fd, buf, sizeof(buf));
     if (size > 0) {
         qemu_send_packet(s->vc, buf, size);
     }
-- 
1.6.0.6