From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Wysochanski Date: Tue, 19 May 2009 11:50:53 -0400 Subject: [PATCH] Re: [lvm-devel] lvconvert error when converting a linear to a mirror In-Reply-To: <87k54dbnwr.fsf_-_@mornfall.net> References: <1242327416.3943.82.camel@f10-node1> <4A113CE0.3080308@ce.jp.nec.com> <87k54dbnwr.fsf_-_@mornfall.net> Message-ID: <1242748253.2418.0.camel@f10-node1> List-Id: To: lvm-devel@redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, 2009-05-19 at 08:35 +0200, Petr Rockai wrote: > Hi, > > "Jun'ichi Nomura" writes: > > And a comment for this comment in the code: > > > >> * FIXME This check used to precede mirror->mirror conversion > >> * but didn't affect mirror->linear or linear->mirror. I do > >> * not understand what is its intention, in fact. > > > > if the check wasn't done for mirror-to-linear conversion, that's a bug. > > It seems the bug has been there since the initial version of lvconvert.c. :) > > I am the author of that FIXME comment there. It seems, that Dave's proposal of > adding a lv->status & MIRRORED check is the right solution here. Thanks both > for noticing and explaining the issue, at the time I was implementing lvconvert > --repair, it was not clear to me. > Ack. Thanks for fixing. Just checked in a test for to cover multi-segment linear to mirror conversion.