From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1M6u2A-0002YT-Rr for mharc-grub-devel@gnu.org; Wed, 20 May 2009 18:13:10 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M6u28-0002Wf-Qw for grub-devel@gnu.org; Wed, 20 May 2009 18:13:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M6u23-0002VM-OC for grub-devel@gnu.org; Wed, 20 May 2009 18:13:08 -0400 Received: from [199.232.76.173] (port=50394 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M6u23-0002VJ-Kq for grub-devel@gnu.org; Wed, 20 May 2009 18:13:03 -0400 Received: from c60.cesmail.net ([216.154.195.49]:38890) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1M6u23-0006Qt-4r for grub-devel@gnu.org; Wed, 20 May 2009 18:13:03 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 20 May 2009 18:13:01 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 42D7534C6D for ; Wed, 20 May 2009 18:14:17 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <4A1478C1.5000906@t-online.de> References: <1242689772.16522.1.camel@mj> <1242692278.26306.3.camel@mj> <1M6P7a-0SfD5U0@fwd04.aul.t-online.de> <4A1478C1.5000906@t-online.de> Content-Type: text/plain Date: Wed, 20 May 2009 18:13:00 -0400 Message-Id: <1242857580.2555.2.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 (2.26.1-2.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] ata.mod under qemu X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2009 22:13:09 -0000 On Wed, 2009-05-20 at 23:40 +0200, Christian Franke wrote: > The attached patch should fix this. It should also prevents misleading > error messages if a device does not exist. > > 2009-05-20 Christian Franke > > * disk/ata.c: (grub_ata_wait_not_busy): Add debug output of status > register. > (grub_ata_identify): Suppress error message if status register > is 0x00 after command failure. > (grub_device_initialize): Remove unsafe status register check. > Thanks to 'phcoder' for problem report and patch. > Prevent sign extension in debug message. It helps detect CD-ROM under qemu. But on the real hardware, it introduces ghost drives. Without the patch, I have (ata7) for the SATA hard drive. With the patch, I have (ata7) for the SATA hard drive, (ata6) for the SATA DVD-RW and two bogus unreadable drives (ata0) and (ata1). -- Regards, Pavel Roskin