From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1M7c8Y-0006RI-IP for mharc-grub-devel@gnu.org; Fri, 22 May 2009 17:18:42 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M7c8W-0006Qk-Mb for grub-devel@gnu.org; Fri, 22 May 2009 17:18:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M7c8R-0006Jv-PQ for grub-devel@gnu.org; Fri, 22 May 2009 17:18:40 -0400 Received: from [199.232.76.173] (port=45269 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M7c8R-0006Jq-Ks for grub-devel@gnu.org; Fri, 22 May 2009 17:18:35 -0400 Received: from c60.cesmail.net ([216.154.195.49]:18367) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1M7c8R-0002m1-9e for grub-devel@gnu.org; Fri, 22 May 2009 17:18:35 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 22 May 2009 17:18:23 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id D885E34C6A for ; Fri, 22 May 2009 17:19:58 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090522043638.10755.42855.stgit@ct.roinet.com> References: <20090522043632.10755.77091.stgit@ct.roinet.com> <20090522043638.10755.42855.stgit@ct.roinet.com> Content-Type: text/plain Date: Fri, 22 May 2009 17:18:24 -0400 Message-Id: <1243027104.2174.8.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 (2.26.1-2.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH 2/2] Eliminate incorrect check for grub_I386_CHECK_REGPARM_BUG X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2009 21:18:40 -0000 On Fri, 2009-05-22 at 00:36 -0400, Pavel Roskin wrote: > NESTED_FUNC_ATTR is defined to "__attribute__ ((__regparm__ (1))" for > i386 targets regardless of the outcome of the test. Since > NESTED_FUNC_ATTR is on the way out, a better test won't be written. > > To be safe, define NESTED_FUNC_ATTR whenever we are compiling the > specific file for i386 architecture, even the target platform is not > i386 (i.e. compiling utilities when the host is i386 and the target is > not). > > ChangeLog: > > * aclocal.m4 (grub_I386_CHECK_REGPARM_BUG): Remove. > * configure.ac: Don't call grub_I386_CHECK_REGPARM_BUG. Define > NESTED_FUNC_ATTR by AH_BOTTOM. Base NESTED_FUNC_ATTR value > solely on the compile time architecture. I've committed this with a minor change. regparm(1) is not used for the utilities, as they are compiled without -mregparm(3). This fixes grub-setup on i386. We still need to get rid of NESTED_FUNC_ATTR eventually, but the immediate user-visible issue is resolved now. -- Regards, Pavel Roskin