Re: [PATCH 2/3] iwmc3200wifi: shrink calibration lmac name

[Marcel Holtmann <holtmann@linux.intel.com>]

Hi Yi,

> > > Firmware names can not be longer than 30 characters, and
> > > iwmc3200wifi-lmac-calib-sdio.bin is too long.
> > > Renaming it to iwmc3200wifi-calib-sdio.bin.
> > 
> > hold on with this one. This limit should _NOT_ exist. Is this an issue
> > in the driver model?
> 
> It should be FW_LOADER framework implementation limitation.
> 
> request_firmware()
>   -> fw_setup_device()
>        -> fw_register_device()
> 
> fw_register_device()
> {
> 	...
> 	strlcpy(fw_priv->fw_id, fw_name, FIRMWARE_NAME_MAX);
> 	...
> }
> 
> FIRMWARE_NAME_MAX is defined 30 at this time.

I think we need to fix this. Especially since all the other name length
limits in the driver model are gone.

Regards

Marcel