From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Arjan van de Ven <arjan@linux.intel.com>,
SCSI development list <linux-scsi@vger.kernel.org>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: Bug in SCSI async probing
Date: Tue, 26 May 2009 10:34:23 -0500 [thread overview]
Message-ID: <1243352063.2815.34.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0905261040230.5554-100000@iolanthe.rowland.org>
On Tue, 2009-05-26 at 11:22 -0400, Alan Stern wrote:
> James & Arjan:
>
> Am I missing something here? It looks like
>
> fastboot: make scsi probes asynchronous
>
> has introduced a bug in the sd probing code. AFAICT, there is now
> nothing to prevent do_scan_async() from returning before
> sd_probe_async() has run.
True, but this isn't really a problem.
> Doesn't this mean that there's nothing to prevent sd_remove() from
> being called and trying to unregister the disk _before_
> sd_probe_async() has managed to register it?
Yes, we've been discussing this ... most of the removal functions now
need async_synchronize calls to mitigate this type of race.
James
next prev parent reply other threads:[~2009-05-26 15:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 15:22 Bug in SCSI async probing Alan Stern
2009-05-26 15:34 ` James Bottomley [this message]
2009-05-26 18:34 ` Alan Stern
2009-05-26 18:56 ` James Bottomley
2009-05-26 19:48 ` Alan Stern
2009-05-26 20:35 ` James Bottomley
2009-05-26 21:04 ` Alan Stern
2009-05-26 21:23 ` James Bottomley
2009-05-26 21:52 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243352063.2815.34.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.