Re: [PATCH] busybox: allow building when prefix is "", not "/usr".

[Phil Blundell <pb@reciva.com>]

On Mon, 2009-05-25 at 23:40 -0400, Michael Smith wrote:
> On Mon, 25 May 2009, Michael Smith wrote:
> 
> > +	for i in ${D}${base_bindir} ${D}${base_sbindir} ${prefix:+${D}${prefix}}
> > +	do
> >  		if [ -d $i ]; then
> > -			cp -dPr $i ${D}/busybox/
> > +			cp -pPR $i ${D}/busybox/
> >  		fi
> >  	done
> 
> I missed this in the commit message: I changed cp -dPr -> -pPR to match 
> the options given a few lines above. -d implies -P, and -r/-R are 
> equivalent, so I suspected a typo. I'll resend with a new description.

Good spotting.  There seems to be more wrong with this code than that,
though: the comment above says "Move everything to /busybox...", but the
code (both before and after your change) seems to copy rather than
moving which would appear to defeat the point of this whole block of
code.  We had a discussion about this on IRC a few weeks ago but I don't
think there was any real conclusion to that.

It looks from the git history as though this stuff has been broken for a
while (since busybox_1.9.1 at least) but I didn't have the patience to
chase it back any further than that. 

Anyway, if you felt like having a go at fixing this too, that'd be
awesome. 

p.