From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: Code standards
Date: Wed, 27 May 2009 16:27:33 +0200 [thread overview]
Message-ID: <1243434453.3043.4.camel@localhost.localdomain> (raw)
In-Reply-To: <200905271546.29540.remi.denis-courmont@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
Hi Remi,
> I assume the coding styles are the "usual" ones, and the last thing I want is
> to start a flame war about those. But which C dialect is Ofono supposed to be
> written in? plain C89, C89 syntax + C99 library, full C99, GNU C... ?
the coding style of oFono is the same as for the Linux kernel, BlueZ,
ConnMan, obexd etc. So basically checkpatch.pl patches are fine.
When using ./bootstrap-configure is used it enables a certain set of GCC
warnings and it should be warnings free. So that is good measurement for
the style details ;)
Regards
Marcel
next prev parent reply other threads:[~2009-05-27 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 12:46 Code standards =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2009-05-27 14:27 ` Marcel Holtmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-05-28 8:13 =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2009-05-28 15:08 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243434453.3043.4.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.