From: Alexey Klimov <klimov.linux@gmail.com>
To: Linux Media <linux-media@vger.kernel.org>
Cc: Douglas Schilling Landgraf <dougsland@gmail.com>
Subject: [patch review 1/4] dsbr100: remove radio->users counter
Date: Fri, 29 May 2009 00:44:33 +0400 [thread overview]
Message-ID: <1243543473.6713.41.camel@tux.localhost> (raw)
Patch removes radio->users counter because it is not in use.
Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
--
diff -r 315bc4b65b4f linux/drivers/media/radio/dsbr100.c
--- a/linux/drivers/media/radio/dsbr100.c Sun May 17 12:28:55 2009 +0000
+++ b/linux/drivers/media/radio/dsbr100.c Tue May 19 15:05:02 2009 +0400
@@ -146,7 +146,6 @@
struct mutex lock; /* buffer locking */
int curfreq;
int stereo;
- int users;
int removed;
int muted;
};
@@ -552,14 +551,12 @@
int retval;
lock_kernel();
- radio->users = 1;
radio->muted = 1;
retval = dsbr100_start(radio);
if (retval < 0) {
dev_warn(&radio->usbdev->dev,
"Radio did not start up properly\n");
- radio->users = 0;
unlock_kernel();
return -EIO;
}
@@ -581,10 +578,6 @@
if (!radio)
return -ENODEV;
- mutex_lock(&radio->lock);
- radio->users = 0;
- mutex_unlock(&radio->lock);
-
if (!radio->removed) {
retval = dsbr100_stop(radio);
if (retval < 0) {
@@ -698,7 +691,6 @@
mutex_init(&radio->lock);
radio->removed = 0;
- radio->users = 0;
radio->usbdev = interface_to_usbdev(intf);
radio->curfreq = FREQ_MIN * FREQ_MUL;
--
Best regards, Klimov Alexey
reply other threads:[~2009-05-28 20:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243543473.6713.41.camel@tux.localhost \
--to=klimov.linux@gmail.com \
--cc=dougsland@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.