From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MA4w4-0004as-2i for mharc-grub-devel@gnu.org; Fri, 29 May 2009 12:28:00 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MA4w2-0004aZ-TE for grub-devel@gnu.org; Fri, 29 May 2009 12:27:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MA4vy-0004Yd-4Q for grub-devel@gnu.org; Fri, 29 May 2009 12:27:58 -0400 Received: from [199.232.76.173] (port=60006 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MA4vx-0004YZ-UN for grub-devel@gnu.org; Fri, 29 May 2009 12:27:53 -0400 Received: from c60.cesmail.net ([216.154.195.49]:23625) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MA4vx-0004op-IT for grub-devel@gnu.org; Fri, 29 May 2009 12:27:53 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 29 May 2009 12:27:46 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 39BB134C6D for ; Fri, 29 May 2009 12:30:20 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1243598750.3544.9.camel@fz.local> References: <1243598750.3544.9.camel@fz.local> Content-Type: text/plain Date: Fri, 29 May 2009 12:27:45 -0400 Message-Id: <1243614465.12433.21.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 (2.26.1-2.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: making the --no-floopy option of grub-install more descriptive X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2009 16:27:59 -0000 On Fri, 2009-05-29 at 14:05 +0200, Felix Zielcke wrote: > Hi, > > on a Debian bug report [0] someone complained that the --no-floppy > option should be better documented in the man page, because it only > works if device.map doestn't exist or --recheck is given and he was > confused of this. For --no-floppy not to work, grub-install would have to probe the floppy when --no-floppy is used. I don't see the evidence of it happening. > But it's generated from the --help output and I'm not that sure to make > it longer. > Or would something like this be okay? > > Index: util/i386/pc/grub-install.in > =================================================================== > --- util/i386/pc/grub-install.in (revision 2237) > +++ util/i386/pc/grub-install.in (working copy) > @@ -65,7 +65,8 @@ Install GRUB on your drive. > --grub-mkimage=FILE use FILE as grub-mkimage > --grub-mkdevicemap=FILE use FILE as grub-mkdevicemap > --grub-probe=FILE use FILE as grub-probe > - --no-floppy do not probe any floppy drive > + --no-floppy do not probe any floppy drive. Works only if > + device.map doestn't exit or --recheck is > given First of all, please check spelling of your patches. Many options in many programs have effect only if some other options are used or not used. It's a minor technical detail. Such details may belong to manuals, but perhaps not at this stage of development. In my opinion, the whole idea of probing all hardware in the system is broken. grub-install cannot predict how BIOS would see the devices. So "--no-floppy" can go away before the next stable release. We could reverse the logic and not probe floppies by default. But I'm not sure it's worth the trouble. We really need to support installation on non-probed devices. Then we can limit the probing to the cases when it's explicitly requested. -- Regards, Pavel Roskin