From: David Aguilar <davvid@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, peff@peff.net, markus.heidelberg@web.de,
jnareb@gmail.com, j.sixt@viscovery.net,
David Aguilar <davvid@gmail.com>
Subject: [PATCH v5 2/3] path: add a find_basename() portability function
Date: Fri, 29 May 2009 19:18:09 -0700 [thread overview]
Message-ID: <1243649890-4522-2-git-send-email-davvid@gmail.com> (raw)
In-Reply-To: <1243649890-4522-1-git-send-email-davvid@gmail.com>
find_basename() is a simpler version of basename().
It maintains constness and thus does not require you
to pass in a copy. It is only concerned with finding
the last directory separator in a string and returning
a pointer.
This function was written because Windows does not
have basename(). It is called "find_basename()"
to avoid name collisions and to provide a hint that
it is not quite the same thing as POSIX basename().
Signed-off-by: David Aguilar <davvid@gmail.com>
---
As suggested by Peff.
cache.h | 1 +
path.c | 14 ++++++++++++++
2 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/cache.h b/cache.h
index b8503ad..08b6f42 100644
--- a/cache.h
+++ b/cache.h
@@ -640,6 +640,7 @@ static inline int is_absolute_path(const char *path)
return path[0] == '/' || has_dos_drive_prefix(path);
}
int is_directory(const char *);
+const char *find_basename(const char *path);
const char *make_absolute_path(const char *path);
const char *make_nonrelative_path(const char *path);
const char *make_relative_path(const char *abs, const char *base);
diff --git a/path.c b/path.c
index 8a0a674..7a2fe14 100644
--- a/path.c
+++ b/path.c
@@ -358,6 +358,20 @@ int set_shared_perm(const char *path, int mode)
return 0;
}
+/* return the basename of a path */
+const char *find_basename(const char *path)
+{
+ const char *basename = path + strlen(path) - 1;
+ while(*basename && basename > path) {
+ basename--;
+ if (is_dir_sep(*basename)) {
+ basename++;
+ break;
+ }
+ }
+ return basename;
+}
+
const char *make_relative_path(const char *abs, const char *base)
{
static char buf[PATH_MAX + 1];
--
1.6.3.1.178.g4daa97
next prev parent reply other threads:[~2009-05-30 2:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-30 2:18 [PATCH v5 1/3] compat: add a mkstemps() compatibility function David Aguilar
2009-05-30 2:18 ` David Aguilar [this message]
2009-05-30 2:18 ` [PATCH v5 3/3] diff: generate pretty filenames in prep_temp_blob() David Aguilar
2009-05-30 14:05 ` [PATCH v5 2/3] path: add a find_basename() portability function Jeff King
2009-05-30 22:14 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243649890-4522-2-git-send-email-davvid@gmail.com \
--to=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=jnareb@gmail.com \
--cc=markus.heidelberg@web.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.