All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pascal Terjan <pterjan@mandriva.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@vger.kernel.org
Subject: Re: SiS 191 failure with MTU > 1496
Date: Tue, 02 Jun 2009 16:14:44 +0200	[thread overview]
Message-ID: <1243952084.19053.111.camel@plop> (raw)
In-Reply-To: <1243943449.19053.96.camel@plop>

Le mardi 02 juin 2009 à 13:50 +0200, Pascal Terjan a écrit :
> Le samedi 30 mai 2009 à 00:30 +0200, Francois Romieu a écrit :
> > Pascal Terjan <pterjan@mandriva.com> :
> > [...]
> > > Oh and even
> > > http://bugzilla.kernel.org/show_bug.cgi?id=10694
> > 
> > Yes, it sucks.
> > 
> > > Should I add some info there ?
> > 
> > Not yet but could you retry with RX_BUF_SIZE set to 1544,
> > 1528 and 1520 ?
> > 
> 
> 1544, 1528 and 1520 fail the same way

By the way there is some strange code:

tp->rx_buf_sz = (mtu > RX_BUF_SIZE) ? mtu + ETH_HLEN + 8 : RX_BUF_SIZE;

Isn't there a (different from the one I'm interested in :) ) bug when
1500 < mtu <= RX_BUF_SIZE

Shouldn't the test be (mtu > ETH_DATA_LEN) ?


      reply	other threads:[~2009-06-02 14:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-29 16:44 SiS 191 failure with MTU > 1496 Pascal Terjan
2009-05-29 16:50 ` Pascal Terjan
2009-05-29 17:00   ` Pascal Terjan
2009-05-29 22:30     ` Francois Romieu
2009-06-02 11:50       ` Pascal Terjan
2009-06-02 14:14         ` Pascal Terjan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1243952084.19053.111.camel@plop \
    --to=pterjan@mandriva.com \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.