From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MBxvV-00089v-I6 for mharc-grub-devel@gnu.org; Wed, 03 Jun 2009 17:23:13 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MBxvT-00086l-JQ for grub-devel@gnu.org; Wed, 03 Jun 2009 17:23:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MBxvQ-00080d-1r for grub-devel@gnu.org; Wed, 03 Jun 2009 17:23:11 -0400 Received: from [199.232.76.173] (port=35070 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MBxvP-00080F-MH for grub-devel@gnu.org; Wed, 03 Jun 2009 17:23:07 -0400 Received: from c60.cesmail.net ([216.154.195.49]:1587) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MBxvP-0003Gy-7T for grub-devel@gnu.org; Wed, 03 Jun 2009 17:23:07 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 03 Jun 2009 17:23:06 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id ABED934C6D for ; Wed, 3 Jun 2009 17:26:26 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1244026488.5031.2.camel@akroma.ephaone.org> References: <98CCCF83-70FB-4EC3-A27C-D184D14AB95D@mandriva.org> <20090207210244.GL988@thorin> <7A5F880B-2772-4E4F-AD16-BC861AACC216@mandriva.org> <1244015775.2297.46.camel@akroma.ephaone.org> <1244026488.5031.2.camel@akroma.ephaone.org> Content-Type: text/plain Date: Wed, 03 Jun 2009 17:23:05 -0400 Message-Id: <1244064185.20653.37.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 (2.26.1-2.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] support of hfsx ( case comparaison ) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jun 2009 21:23:11 -0000 Hello! I think the ChangeLog needs to be improved. It's immodest to claim "complete" support for something. It's a very strong statement. It's better to say "improve". Or better yet, let's be specific. Also please spell check the entry. "insensitive" and "insentive" is not the same. You want the former. Please end sentences with a period. I would write the ChangeLog entry as: * fs/hfsplus.c: Use case sensitive comparison for hfsx when required by the filesystem settings. Actually, it would be better to list the functions involved. I just want to show how long descriptions can be improved. I also prefer not to use any negative logic, and it's easier to get it wrong. Humans are notoriously bad at logic. Let's have grub_hfsplus_is_case_sensitive(). I would write it like this: static inline int grub_hfsplus_is_case_sensitive (struct grub_hfsplus_data *data) { if ((grub_be_to_cpu16 (data->volheader.magic) == GRUB_HFSPLUSX_MAGIC) && (data->catalog_cmp_key == GRUB_HFSPLUSX_BINARYCOMPARE)) return 1; else return 0; } No need to handle unknown magic numbers. We may need to use a comparison table as in hfs.c, as least for the first 256 Unicode characters, but it's a separate issue. -- Regards, Pavel Roskin