From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MBygZ-0004Hu-OP for mharc-grub-devel@gnu.org; Wed, 03 Jun 2009 18:11:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MBygY-0004Ey-61 for grub-devel@gnu.org; Wed, 03 Jun 2009 18:11:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MBygT-00043Q-Mc for grub-devel@gnu.org; Wed, 03 Jun 2009 18:11:49 -0400 Received: from [199.232.76.173] (port=37794 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MBygT-00043H-JZ for grub-devel@gnu.org; Wed, 03 Jun 2009 18:11:45 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]:54621) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MBygS-00043Y-Tk for grub-devel@gnu.org; Wed, 03 Jun 2009 18:11:45 -0400 Received: from [85.180.52.120] (e180052120.adsl.alicedsl.de [85.180.52.120]) by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis) id 0MKt2u-1MBygR3Uzj-0006Ac; Thu, 04 Jun 2009 00:11:44 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <1244062540.20653.11.camel@mj> References: <1244022215.3429.17.camel@fz.local> <1244062540.20653.11.camel@mj> Content-Type: multipart/mixed; boundary="=-6PjjMA0ZzzgXpVQ0N3et" Date: Thu, 04 Jun 2009 00:11:42 +0200 Message-Id: <1244067102.3407.51.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 X-Provags-ID: V01U2FsdGVkX18VTjNIl5Qf2BfNM2gl1fzxXqpZlEtQ/Iy2ltM Mx7D+foOa/79o+db3ICUIEwVWzYGmaxD51VeO7QxVKfE+zBG1B V10OtOVJUJ/lF1NqPAccRv0P1Ks0gmV X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: grub-mkconfig fails on every non i386-pc because of gfxterm/vbe X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jun 2009 22:11:50 -0000 --=-6PjjMA0ZzzgXpVQ0N3et Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Am Mittwoch, den 03.06.2009, 16:55 -0400 schrieb Pavel Roskin: > On Wed, 2009-06-03 at 11:43 +0200, Felix Zielcke wrote: > > I wonder why nobody on this list noticed this yet. > > Jordi reported this already on Debian a while ago [0] > >=20 > > It fails with `No suitable backend could be found for gfxterm.' > > The problem is that gfxterm is used when nothing is explicitly specifie= d > > and the fonts were compiled, but the fails because vbe.mod only gets > > compiled for i386-pc whereas gfxterm.mod gets compiled for every arches= . >=20 > It looks like a conflict between grub-mkconfig and 00_header. > grub-mkconfig sets GRUB_TERMINAL_OUTPUT to gfxterm because gfxterm.mod > is present, but 00_header refuses to use it because vbe.mod is absent. >=20 > Or maybe Debian sets GRUB_TERMINAL_OUTPUT to gfxterm somewhere. No, by default we don't set GRUB_TERMINAL_OUTPUT at all. > > I suggest as Jordi to just change the `exit 1' to =C2=B4exit 0' and tel= ling > > the user that it falls back to native terminal: >=20 > I believe it's a wrong fix, as it would not prevent adding the gfxterm > code to grub.cfg. Yes it won't. It would only prevent it from completely failing if gfxterm isn't avaible. > I believe the fix belongs to grub-mkconfig (if it's not a Debian > specific issue). Setting defaults in grub-mkconfig should be done very > carefully, as the numbered scripts treat those defaults as explicit > requests by the user. So you would prefer something like the attached patch? Though then we'll need to tell people to explicit enable gfxterm. --=20 Felix Zielcke --=-6PjjMA0ZzzgXpVQ0N3et Content-Disposition: attachment; filename="mkconfig-gfxterm.patch" Content-Type: text/x-patch; name="mkconfig-gfxterm.patch"; charset="UTF-8" Content-Transfer-Encoding: 7bit 2009-06-03 Felix Zielcke * util/grub-mkconfig.in: Don't use gfxterm by default if not explicit specified by the user. diff --git a/util/grub-mkconfig.in b/util/grub-mkconfig.in index ff92590..8f84074 100644 --- a/util/grub-mkconfig.in +++ b/util/grub-mkconfig.in @@ -137,13 +137,7 @@ if [ "x${GRUB_TERMINAL}" != "x" ] ; then fi case x${GRUB_TERMINAL_OUTPUT} in - x) - # If this platform supports gfxterm, try to use it. - if test -e ${grub_prefix}/gfxterm.mod ; then - GRUB_TERMINAL_OUTPUT=gfxterm - fi - ;; - xconsole | xserial | xofconsole | xgfxterm) ;; + x | xconsole | xserial | xofconsole | xgfxterm) ;; *) echo "Invalid output terminal \"${GRUB_TERMINAL_OUTPUT}\"" >&2 ; exit 1 ;; esac --=-6PjjMA0ZzzgXpVQ0N3et--