From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1MCV51-0002dY-KX
	for mharc-grub-devel@gnu.org; Fri, 05 Jun 2009 04:47:15 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MCV50-0002dK-BM
	for grub-devel@gnu.org; Fri, 05 Jun 2009 04:47:14 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MCV4v-0002ch-Sb
	for grub-devel@gnu.org; Fri, 05 Jun 2009 04:47:13 -0400
Received: from [199.232.76.173] (port=47063 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MCV4v-0002ce-NS
	for grub-devel@gnu.org; Fri, 05 Jun 2009 04:47:09 -0400
Received: from moutng.kundenserver.de ([212.227.126.187]:60894)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <fzielcke@z-51.de>) id 1MCV4v-0001Pw-8k
	for grub-devel@gnu.org; Fri, 05 Jun 2009 04:47:09 -0400
Received: from [85.180.42.67] (e180042067.adsl.alicedsl.de [85.180.42.67])
	by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis)
	id 0MKv1o-1MCV4s2WrZ-000jnF; Fri, 05 Jun 2009 10:47:06 +0200
From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
In-Reply-To: <874ouwcst9.fsf@xs4all.nl>
References: <1243426603.3425.2.camel@fz.local>
	<d7ead6de0905300814l74dda76bwdabe2373df567b8a@mail.gmail.com>
	<1243865933.3417.2.camel@fz.local>
	<d7ead6de0906010724n30a2dcd3rb1b9c5d3553494e5@mail.gmail.com>
	<1244043954.3407.4.camel@fz.local>  <874ouwcst9.fsf@xs4all.nl>
Content-Type: text/plain
Date: Fri, 05 Jun 2009 10:47:03 +0200
Message-Id: <1244191623.3416.1.camel@fz.local>
Mime-Version: 1.0
X-Mailer: Evolution 2.26.2 
Content-Transfer-Encoding: 7bit
X-Provags-ID: V01U2FsdGVkX1/YJiCGdsRig54CPw6ZuBGAt6xN+d38d+/BGrf
	cPm7PfMdAUx71QueDcPqCAwqwPyZTVZ3eQMz69jYAJLqEyob4W
	z1WeuFEAzU8Bnn6zmke0w==
X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not
	recognized.
Subject: Re: [PATCH] add true and false commands
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Jun 2009 08:47:14 -0000

Am Donnerstag, den 04.06.2009, 10:21 +0200 schrieb Marco Gerards:
> Felix Zielcke <fzielcke@z-51.de> writes:
> 
> > Am Montag, den 01.06.2009, 16:24 +0200 schrieb Vladimir 'phcoder'
> > Serbinenko:
> >> However convention for
> >> creating false is:
> >>   return grub_error (GRUB_ERR_TEST_FAILURE, "false");
> >> and not
> >>   return 1;
> >
> > Ok changed it. If everyone is fine with placing this in normal/main.c, I
> > commit it.
> 
> Unless it is essential to do so, please do not place it in
> normal/main.c.
> 

would normal/misc.c be okay or maybe a new file normal/true.c?
I just don't think it's worth to create a new module for these 2 very
little commands.
-- 
Felix Zielcke