From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MCWjE-0003ww-1w for mharc-grub-devel@gnu.org; Fri, 05 Jun 2009 06:32:52 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MCWjB-0003wZ-RM for grub-devel@gnu.org; Fri, 05 Jun 2009 06:32:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MCWj7-0003vp-70 for grub-devel@gnu.org; Fri, 05 Jun 2009 06:32:49 -0400 Received: from [199.232.76.173] (port=44215 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MCWj6-0003vk-U6 for grub-devel@gnu.org; Fri, 05 Jun 2009 06:32:44 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]:60564) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MCWj6-00047H-8I for grub-devel@gnu.org; Fri, 05 Jun 2009 06:32:44 -0400 Received: from [85.180.42.67] (e180042067.adsl.alicedsl.de [85.180.42.67]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0MKv5w-1MCWj51ErS-0001zU; Fri, 05 Jun 2009 12:32:43 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <874ouvxao0.fsf@xs4all.nl> References: <1243426603.3425.2.camel@fz.local> <1243865933.3417.2.camel@fz.local> <1244043954.3407.4.camel@fz.local> <874ouwcst9.fsf@xs4all.nl> <1244191623.3416.1.camel@fz.local> <874ouvxao0.fsf@xs4all.nl> Content-Type: text/plain Date: Fri, 05 Jun 2009 12:32:42 +0200 Message-Id: <1244197962.3416.13.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1+Ir/Pi6YFALQjk3NmpLtOkYMbMuz5G2RXfOG7 J2HzgpHT5gBfU6wSRYIcR+DfEyQOmjYfVipMrpW9Lba7DT/ijo jowL1MMi8Ig08s9JxSzzQ== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] add true and false commands X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2009 10:32:50 -0000 Am Freitag, den 05.06.2009, 12:00 +0200 schrieb Marco Gerards: > Felix Zielcke writes: > > > Am Donnerstag, den 04.06.2009, 10:21 +0200 schrieb Marco Gerards: > >> Felix Zielcke writes: > >> > >> > Am Montag, den 01.06.2009, 16:24 +0200 schrieb Vladimir 'phcoder' > >> > Serbinenko: > >> >> However convention for > >> >> creating false is: > >> >> return grub_error (GRUB_ERR_TEST_FAILURE, "false"); > >> >> and not > >> >> return 1; > >> > > >> > Ok changed it. If everyone is fine with placing this in normal/main.c, I > >> > commit it. > >> > >> Unless it is essential to do so, please do not place it in > >> normal/main.c. > > > > would normal/misc.c be okay or maybe a new file normal/true.c? > > I just don't think it's worth to create a new module for these 2 very > > little commands. > > The problem is with too many little commands, the size of normal.mod > grows. Although the commands are *very* small and I do not strongly > object to inclusion in normal.mod, if noone else has any objection. The binary size of normal.mod would grow about 264 bytes whereas in minicmd.mod it would be just 260 bytes. But I already forgot that Bean wants to get rid of normal.mod. So what should I do now? Placing it in normal.mod or minicmd.mod where it's included in rescue mode or placing it into a true.mod where the size increase would be bigger? -- Felix Zielcke