From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MCZ61-0007bX-IA for mharc-grub-devel@gnu.org; Fri, 05 Jun 2009 09:04:33 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MCZ5z-0007aJ-D1 for grub-devel@gnu.org; Fri, 05 Jun 2009 09:04:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MCZ5u-0007YI-1j for grub-devel@gnu.org; Fri, 05 Jun 2009 09:04:30 -0400 Received: from [199.232.76.173] (port=58502 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MCZ5t-0007Y8-OM for grub-devel@gnu.org; Fri, 05 Jun 2009 09:04:25 -0400 Received: from moutng.kundenserver.de ([212.227.17.9]:63463) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MCZ5t-0005ds-1u for grub-devel@gnu.org; Fri, 05 Jun 2009 09:04:25 -0400 Received: from [85.180.42.67] (e180042067.adsl.alicedsl.de [85.180.42.67]) by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis) id 0MKt2u-1MCZ5r2eGS-00069i; Fri, 05 Jun 2009 15:04:23 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <87zlcmx3ws.fsf@xs4all.nl> References: <1243426603.3425.2.camel@fz.local> <1243865933.3417.2.camel@fz.local> <1244043954.3407.4.camel@fz.local> <874ouwcst9.fsf@xs4all.nl> <1244191623.3416.1.camel@fz.local> <874ouvxao0.fsf@xs4all.nl> <1244197962.3416.13.camel@fz.local> <87zlcmx3ws.fsf@xs4all.nl> Content-Type: multipart/mixed; boundary="=-TMyCWq1FVs4+LSajw1sQ" Date: Fri, 05 Jun 2009 15:04:22 +0200 Message-Id: <1244207062.3416.45.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 X-Provags-ID: V01U2FsdGVkX19IS3xIXWVJZv8ffPBWN3KP2R+ffY7VnSpDlhI xzny9iOPnC7c4V9zPAjxSBnK2vMeXz9bRpPBUNt5FH+CJnv74U C4/UYLBvT4Dsr+HgJ3xtClabgqz3AZ3 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] add true and false commands X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2009 13:04:32 -0000 --=-TMyCWq1FVs4+LSajw1sQ Content-Type: text/plain Content-Transfer-Encoding: 7bit Am Freitag, den 05.06.2009, 14:26 +0200 schrieb Marco Gerards: > Felix Zielcke writes: > > So what should I do now? > > Placing it in normal.mod or minicmd.mod where it's included in rescue > > mode or placing it into a true.mod where the size increase would be > > bigger? > > minicmd.mod is not a very descriptive name. Better call is > truefalse.mod or something like that. minicmd.mod already exists, see commands/minicmd.c (or my first patch). That's where I put it in the first patch. Anyway here's a new one which adds true.mod which gets 1264 bytes big. Thanks Marco that you take the time for it. -- Felix Zielcke --=-TMyCWq1FVs4+LSajw1sQ Content-Disposition: attachment; filename="true_false.patch.4" Content-Type: text/plain; name="true_false.patch.4"; charset="UTF-8" Content-Transfer-Encoding: 7bit 2009-06-05 Felix Zielcke * commands/true.c: New file. Implement the true and false commands. * conf/common.rmk.c (pkglib_MODULES): Add `true.mod'. (true_mod_SOURCES): New variable. (true_mod_CFLAGS): Likewise. (true_mod_LDFLAGS): Likewise. diff --git a/commands/true.c b/commands/true.c index e69de29..16ca315 100644 --- a/commands/true.c +++ b/commands/true.c @@ -0,0 +1,56 @@ +/* true.c - true and false commands. */ +/* + * GRUB -- GRand Unified Bootloader + * Copyright (C) 2009 Free Software Foundation, Inc. + * + * GRUB is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * GRUB is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with GRUB. If not, see . + */ + +#include +#include + +static grub_err_t +grub_cmd_true (struct grub_command *cmd __attribute__ ((unused)), + int argc __attribute__ ((unused)), + char *argv[] __attribute__ ((unused))) +{ + return 0; +} + +static grub_err_t +grub_cmd_false (struct grub_command *cmd __attribute__ ((unused)), + int argc __attribute__ ((unused)), + char *argv[] __attribute__ ((unused))) +{ + return grub_error (GRUB_ERR_TEST_FAILURE, "false"); +} + +static grub_command_t cmd_true, cmd_false; + + +GRUB_MOD_INIT(true) +{ + cmd_true = + grub_register_command ("true", grub_cmd_true, + 0, "do nothing, successfully"); + cmd_false = + grub_register_command ("false", grub_cmd_false, + 0, "do nothing, unsuccessfully"); +} + +GRUB_MOD_FINI(true) +{ + grub_unregister_command (cmd_true); + grub_unregister_command (cmd_false); +} diff --git a/conf/common.rmk b/conf/common.rmk index ca18c53..48565bf 100644 --- a/conf/common.rmk +++ b/conf/common.rmk @@ -344,7 +344,7 @@ pkglib_MODULES += minicmd.mod extcmd.mod hello.mod handler.mod \ terminfo.mod test.mod blocklist.mod hexdump.mod \ read.mod sleep.mod loadenv.mod crc.mod parttool.mod \ pcpart.mod memrw.mod boot.mod normal.mod sh.mod lua.mod \ - gptsync.mod + gptsync.mod true.mod # For gptsync.mod. gptsync_mod_SOURCES = commands/gptsync.c @@ -476,6 +476,11 @@ memrw_mod_SOURCES = commands/memrw.c memrw_mod_CFLAGS = $(COMMON_CFLAGS) memrw_mod_LDFLAGS = $(COMMON_LDFLAGS) +# For true.mod +true_mod_SOURCES = commands/true.c +true_mod_CFLAGS = $(COMMON_CFLAGS) +true_mod_LDFLAGS = $(COMMON_LDFLAGS) + # For normal.mod. normal_mod_SOURCES = normal/main.c normal/cmdline.c normal/dyncmd.c \ normal/autofs.c normal/handler.c \ --=-TMyCWq1FVs4+LSajw1sQ--