From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MCgf7-00085O-HZ for mharc-grub-devel@gnu.org; Fri, 05 Jun 2009 17:09:17 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MCgf1-00080i-5I for grub-devel@gnu.org; Fri, 05 Jun 2009 17:09:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MCget-0007ty-7b for grub-devel@gnu.org; Fri, 05 Jun 2009 17:09:07 -0400 Received: from [199.232.76.173] (port=41962 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MCger-0007tg-QU for grub-devel@gnu.org; Fri, 05 Jun 2009 17:09:01 -0400 Received: from c60.cesmail.net ([216.154.195.49]:3978) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MCgeq-0000Rk-VQ for grub-devel@gnu.org; Fri, 05 Jun 2009 17:09:01 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 05 Jun 2009 17:08:57 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 26DD834C6A for ; Fri, 5 Jun 2009 17:12:35 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1244229804.4857.154.camel@akroma.ephaone.org> References: <98CCCF83-70FB-4EC3-A27C-D184D14AB95D@mandriva.org> <20090207210244.GL988@thorin> <7A5F880B-2772-4E4F-AD16-BC861AACC216@mandriva.org> <1244015775.2297.46.camel@akroma.ephaone.org> <1244026488.5031.2.camel@akroma.ephaone.org> <1244064185.20653.37.camel@mj> <1244229804.4857.154.camel@akroma.ephaone.org> Content-Type: text/plain Date: Fri, 05 Jun 2009 17:08:55 -0400 Message-Id: <1244236135.10875.9.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] support of hfsx ( case comparaison ) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2009 21:09:13 -0000 On Fri, 2009-06-05 at 21:23 +0200, Michael Scherer wrote: > Ok, I have taken in account your remark. Here is another patch. I've applied your patch with two fixes. Somehow you interchanged the values of GRUB_HFSPLUSX_BINARYCOMPARE and GRUB_HFSPLUSX_CASEFOLDING. GRUB_HFSPLUSX_BINARYCOMPARE is 0xBC and GRUB_HFSPLUSX_CASEFOLDING is 0xCF. The values are actually abbreviations. I wonder if you have tested your patch. I have tested the final patch on both case-sensitive and case-insensitive filesystems, and it appears to be OK. Also, it should not be needed to call an inline function from grub_hfsplus_iterate_dir(). It's easier to calculate it once for the filesystem at the mount time. -- Regards, Pavel Roskin