From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MD7ZV-0002PH-AV for mharc-grub-devel@gnu.org; Sat, 06 Jun 2009 21:53:17 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MD7ZT-0002Ni-QB for grub-devel@gnu.org; Sat, 06 Jun 2009 21:53:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MD7ZP-0002Eh-AQ for grub-devel@gnu.org; Sat, 06 Jun 2009 21:53:15 -0400 Received: from [199.232.76.173] (port=47976 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MD7ZP-0002ER-6p for grub-devel@gnu.org; Sat, 06 Jun 2009 21:53:11 -0400 Received: from c60.cesmail.net ([216.154.195.49]:11118) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MD7ZO-0000d8-Ai for grub-devel@gnu.org; Sat, 06 Jun 2009 21:53:10 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 06 Jun 2009 21:53:09 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 32C9E34C6A for ; Sat, 6 Jun 2009 21:56:58 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1244283931.3418.7.camel@fz.local> References: <1244283931.3418.7.camel@fz.local> Content-Type: text/plain Date: Sat, 06 Jun 2009 21:53:07 -0400 Message-Id: <1244339587.18630.8.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: 2273 lines in 170 files consists of only space and tabulators X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Jun 2009 01:53:16 -0000 On Sat, 2009-06-06 at 12:25 +0200, Felix Zielcke wrote: > fz@fz:~/grub/grub2.git$ rgrep -E "^[[:blank:]]+$" *|wc -l > 2273 > fz@fz:~/grub/grub2.git$ rgrep -E "^[[:blank:]]+$" *|sed -e 's/:.*//'|uniq|wc -l > 170 > > Anyone wants me to do > find . -type f -print0 | xargs -0 sed -i -r -e 's/^[[:blank:]]+$//' > or does someone object? > [:blank:] doestn't contain these ^L chars. > > By the way `git diff --color' shows if you introduce such a line with > red, but strangely not when you remove one. Since we have linear development, it shouldn't be a problem for merging patches. Besides, "patch" can be told to ignore whitespace differences. However, I would prefer that we remove all trailing whitespace, not just that on empty lines. That is, remove "^" from the sed expression. As for the script, make sure that it's not run on any special files used by Subversion or git. Maybe use DISTLIST. -- Regards, Pavel Roskin