From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MDKj8-000313-5b for mharc-grub-devel@gnu.org; Sun, 07 Jun 2009 11:56:06 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MDKj6-0002xT-0b for grub-devel@gnu.org; Sun, 07 Jun 2009 11:56:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MDKj1-0002qn-DL for grub-devel@gnu.org; Sun, 07 Jun 2009 11:56:03 -0400 Received: from [199.232.76.173] (port=51246 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MDKj1-0002qi-5y for grub-devel@gnu.org; Sun, 07 Jun 2009 11:55:59 -0400 Received: from c60.cesmail.net ([216.154.195.49]:1724) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MDKj0-0006f0-P3 for grub-devel@gnu.org; Sun, 07 Jun 2009 11:55:58 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 07 Jun 2009 11:55:54 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 5F4CF34C6A for ; Sun, 7 Jun 2009 11:59:48 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1244389079.3791.7.camel@fz.local> References: <1244389079.3791.7.camel@fz.local> Content-Type: text/plain Date: Sun, 07 Jun 2009 11:55:52 -0400 Message-Id: <1244390152.27559.13.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] add drivemap support to 30_os-prober.in and use UUIDs X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Jun 2009 15:56:04 -0000 On Sun, 2009-06-07 at 17:37 +0200, Felix Zielcke wrote: > Attached patch uses `prepare_grub_to_access_device' to set the root in > the generated entrys. > And it adds drivemap to the chainload ones, if root isn't (hd0). > > The Debian grub-installer adds map only with Dos and Windows, should I > do the same or is it okay to do it for all? Perhaps it would be better to avoid it when it's not needed. But it may be tricky to determine what bootloader we are using. Let's do it always and eliminate the cases where it's harmful or definitely useless. > -# update-grub helper script. > +# grub-mkconfig helper script. > Does this needs to be mentioned in ChangeLog? The standard says: 'When you change just comments or doc strings, it is enough to write an entry for the file, without mentioning the functions. Just "Doc fixes" is enough for the change log.' -- Regards, Pavel Roskin