From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MDMMa-0001BF-1Y for mharc-grub-devel@gnu.org; Sun, 07 Jun 2009 13:40:56 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MDMMY-0001Al-Ra for grub-devel@gnu.org; Sun, 07 Jun 2009 13:40:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MDMMU-00018d-8Q for grub-devel@gnu.org; Sun, 07 Jun 2009 13:40:54 -0400 Received: from [199.232.76.173] (port=50801 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MDMMU-00018a-5s for grub-devel@gnu.org; Sun, 07 Jun 2009 13:40:50 -0400 Received: from c60.cesmail.net ([216.154.195.49]:61060) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MDMMT-0003ko-OI for grub-devel@gnu.org; Sun, 07 Jun 2009 13:40:49 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 07 Jun 2009 13:40:45 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 2B24C34C6A for ; Sun, 7 Jun 2009 13:44:40 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <98CCCF83-70FB-4EC3-A27C-D184D14AB95D@mandriva.org> <7A5F880B-2772-4E4F-AD16-BC861AACC216@mandriva.org> <1244015775.2297.46.camel@akroma.ephaone.org> <1244026488.5031.2.camel@akroma.ephaone.org> <1244064185.20653.37.camel@mj> <1244229804.4857.154.camel@akroma.ephaone.org> <1244341120.18630.29.camel@mj> Content-Type: text/plain Date: Sun, 07 Jun 2009 13:40:44 -0400 Message-Id: <1244396444.27559.17.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] support of hfsx ( case comparaison ) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Jun 2009 17:40:55 -0000 On Sun, 2009-06-07 at 11:10 +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sun, Jun 7, 2009 at 4:18 AM, Pavel Roskin wrote: > >> Improving > >> strcasecmp is possible and may even be compact. Even if unicode counts > >> a lot of alphabets only few are bicameral. AFAIK main ones are Latin, > >> Greek, Cyrillic and Armenian. I hope that in most cases the lowercase > >> conversion can be done with some simple arithmetic operations > > > > We are using grub_strcasecmp() on data in other encodings in some cases. > > I think short names on the FAT filesystem are never in UTF-8. > Normally not but fat code passes short filenames to grub without any > encoding conversion. In other words fat code assumes short filenames > are in utf8. A problem in both hfs and fat is that it uses local > encoding and at least in case of fat it's impossible to know which one > from filesystem alone. We would need something like mount option to > get this right. It could be sth like > hd0_0_codepage=437 Fortunately, it would only matter if the user tries to access a file with non-ASCII characters using a capitalization different from the one used by the filesystem. > > Also, > > case comparison depends on the locale. That's too much complexity for > > the code GRUB. I would prefer the case comparison for hfsplus to be in > > the hfsplus module if we decide to implement it correctly. > I agree with you. I see no reason for users to have unicode characters > in kernel names. And so getting it right is too much work for an > almost zero benefit I case of hfsplus, there is a chance to miss a file in the binary tree if there are non-ASCII files in the same directory. But I agree, it's not worth the trouble at this point. -- Regards, Pavel Roskin