From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MDNln-0000GI-MC for mharc-grub-devel@gnu.org; Sun, 07 Jun 2009 15:11:03 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MDNlm-0000G3-6N for grub-devel@gnu.org; Sun, 07 Jun 2009 15:11:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MDNlh-0000Fr-D9 for grub-devel@gnu.org; Sun, 07 Jun 2009 15:11:01 -0400 Received: from [199.232.76.173] (port=54509 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MDNlh-0000Fo-79 for grub-devel@gnu.org; Sun, 07 Jun 2009 15:10:57 -0400 Received: from c60.cesmail.net ([216.154.195.49]:56743) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MDNlg-0007ju-Ra for grub-devel@gnu.org; Sun, 07 Jun 2009 15:10:57 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 07 Jun 2009 15:10:54 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 24F1D34C6A for ; Sun, 7 Jun 2009 15:14:50 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <6d6c12960906071203r6e4a5dfek9a9da7522feaab4e@mail.gmail.com> References: <6d6c12960906071203r6e4a5dfek9a9da7522feaab4e@mail.gmail.com> Content-Type: text/plain Date: Sun, 07 Jun 2009 15:10:53 -0400 Message-Id: <1244401853.27559.25.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: insmod uhci causes computer to reset X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Jun 2009 19:11:02 -0000 On Sun, 2009-06-07 at 20:03 +0100, Oliver Henshaw wrote: > Even with the fixes described previously, grub fails with an UHCI > controller (VIA uhci > chipset on the motherboard). When no devices are attached, module > loading completes > successfully. When a mouse is attached, module loading completes but > listing the device with > 'usb' causes the machine to reset. If I try without 'set debug=uhci' > then 'insmod uhci' causes > the computer to hang. Maybe the crash is in usb_keyboard? I know that term/usb_keyboard.c assumes that there is exactly one USB keyboard. It there is no USB keyboard, the code would crash because usbdev is NULL. Also, the matching of the keyboard is incorrect. It checks the device descriptor (even that code is a hack), but not the interface descriptor. -- Regards, Pavel Roskin