From: Sam Vilain <sam@vilain.net>
To: Nick Edelen <sirnot@gmail.com>
Cc: Nicolas Pitre <nico@cam.org>,
git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Andreas Ericsson <exon@op5.se>,
Christian Couder <christian@couder.net>,
Jeff King <peff@peff.net>
Subject: Re: [WIP] Shift rev-list enumeration from upload-pack to pack-objects
Date: Mon, 08 Jun 2009 08:48:33 +1200 [thread overview]
Message-ID: <1244407713.5870.7.camel@maia.lan> (raw)
In-Reply-To: <c77435a80906071155g5530ccdel286907b7c6022838@mail.gmail.com>
On Sun, 2009-06-07 at 20:55 +0200, Nick Edelen wrote:
> how does this look?
>
> Signed-off-by: Nick Edelen <sirnot@gmail.com>
>
> ---
Comments like that belong after the '---'; the change description is
part of the work that you are developing, too.
Sam.
next prev parent reply other threads:[~2009-06-07 20:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 5:45 [WIP] Shift rev-list enumeration from upload-pack to pack-objects sam, Nick Edelen
2009-06-05 5:46 ` Sam Vilain
2009-06-05 8:10 ` Johannes Sixt
2009-06-08 8:51 ` [PATCH] fetch-pack: close output channel after sideband demultiplexer terminates Johannes Sixt
2009-06-05 16:51 ` [WIP] Shift rev-list enumeration from upload-pack to pack-objects Nicolas Pitre
2009-06-07 13:25 ` Nick Edelen
2009-06-07 13:31 ` Nick Edelen
2009-06-07 16:41 ` Nicolas Pitre
2009-06-07 16:47 ` Nick Edelen
2009-06-07 18:55 ` Nick Edelen
2009-06-07 20:48 ` Sam Vilain [this message]
2009-06-07 20:48 ` Nicolas Pitre
2009-06-07 22:04 ` Nick Edelen
2009-06-08 0:50 ` Nicolas Pitre
2009-06-08 2:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244407713.5870.7.camel@maia.lan \
--to=sam@vilain.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=christian@couder.net \
--cc=exon@op5.se \
--cc=git@vger.kernel.org \
--cc=nico@cam.org \
--cc=peff@peff.net \
--cc=sirnot@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.