From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MDUK9-0004VP-B4 for mharc-grub-devel@gnu.org; Sun, 07 Jun 2009 22:10:57 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MDUK6-0004Pg-PK for grub-devel@gnu.org; Sun, 07 Jun 2009 22:10:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MDUJz-0004CD-Er for grub-devel@gnu.org; Sun, 07 Jun 2009 22:10:51 -0400 Received: from [199.232.76.173] (port=51774 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MDUJz-0004C0-Bz for grub-devel@gnu.org; Sun, 07 Jun 2009 22:10:47 -0400 Received: from c60.cesmail.net ([216.154.195.49]:45019) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MDUJz-0001VA-1i for grub-devel@gnu.org; Sun, 07 Jun 2009 22:10:47 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 07 Jun 2009 22:10:43 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id E448934C6A for ; Sun, 7 Jun 2009 22:14:40 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" Date: Sun, 07 Jun 2009 22:10:41 -0400 Message-Id: <1244427041.2690.10.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 8bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] drivemap fixes X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jun 2009 02:10:55 -0000 On Fri, 2009-06-05 at 16:27 +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello. As suggested by Javier Martín I move this to a new thread. This > patch fixes some problems with determining bios number of a disk. > biosnum is in boot.mod because it's where it will cause the least of > possible core.img increase (3 of 5 loaders on pc need biosnum). > Thisforced to move boot.mod to platform-specific files but this > inflexibility of build system is a subject for another patch I'll appreciate if you also provide ChangeLog. Also, it would be great if you specify, which exactly problems the patch fixes. As for the fixes to the handler, I think they should be submitted separately. Please avoid non-words like "postamble". Comments would be nice. I would try to avoid having two long calls if possible. -- Regards, Pavel Roskin