All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Chan" <mchan@broadcom.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"michaelc@cs.wisc.edu" <michaelc@cs.wisc.edu>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"open-iscsi@googlegroups.com" <open-iscsi@googlegroups.com>
Subject: Re: [PATCH 3/4] iscsi class, libiscsi: Add net config.
Date: Mon, 8 Jun 2009 10:59:34 -0700	[thread overview]
Message-ID: <1244483974.9184.404.camel@HP1> (raw)
In-Reply-To: <1244483774.4079.368.camel@mulgrave.site>


On Mon, 2009-06-08 at 10:56 -0700, James Bottomley wrote:
> On Fri, 2009-05-01 at 13:00 -0700, Michael Chan wrote:
> > Add ISCSI_NETLINK messages to get/set vendor specific information.
> > This is to support bnx2i that handles net config of private iSCSI
> > IP address in userspace.
> > 
> > Signed-off-by: Anil Veerabhadrappa <anilgv@broadcom.com>
> > Signed-off-by: Michael Chan <mchan@broadcom.com>
> > Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
> > Acked-by: David S. Miller <davem@davemloft.net>
> 
> This patch is rejecting pretty badly against both SCSI and net ... is
> there an update (I saw you updated the other three patches in this
> series on the 23rd, but not this one)?
> 

I believe this is an earlier version of the patch.  On the 23rd, I sent
a completely new version after feedback from Mike and Chelsio to
standardize the message format.  It was also re-ordered as patch 1/4.

We have some cleanups we want to make on the bnx2i patch (4/4).  I can
re-spin everything and send out the whole set of patches later today.

Thanks.

> James
> 
> ---
> 
> patching file drivers/scsi/scsi_transport_iscsi.c
> Hunk #1 succeeded at 1015 with fuzz 2 (offset 20 lines).
> Hunk #2 FAILED at 1416.
> Hunk #3 FAILED at 1456.
> Hunk #4 succeeded at 1611 with fuzz 2 (offset 80 lines).
> 2 out of 4 hunks FAILED -- saving rejects to file
> drivers/scsi/scsi_transport_iscsi.c.rej
> patching file include/scsi/iscsi_if.h
> Hunk #1 succeeded at 60 with fuzz 2 (offset 8 lines).
> Hunk #2 FAILED at 69.
> Hunk #3 FAILED at 165.
> Hunk #4 FAILED at 204.
> 3 out of 4 hunks FAILED -- saving rejects to file
> include/scsi/iscsi_if.h.rej
> patching file include/scsi/scsi_transport_iscsi.h
> Hunk #1 FAILED at 132.
> Hunk #2 succeeded at 151 with fuzz 2 (offset 2 lines).
> 1 out of 2 hunks FAILED -- saving rejects to file
> include/scsi/scsi_transport_iscsi.h.rej
> 
> 
> 



  reply	other threads:[~2009-06-08 17:59 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-01 20:00 [PATCH 0/4] Add bnx2 iscsi support Michael Chan
2009-05-01 20:00 ` [PATCH 1/4] bnx2: Add support for CNIC driver Michael Chan
     [not found] ` <1241208039-6813-1-git-send-email-mchan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2009-05-01 20:00   ` [PATCH 2/4] cnic: Add new " Michael Chan
2009-05-01 20:00 ` [PATCH 3/4] iscsi class, libiscsi: Add net config Michael Chan
     [not found]   ` <1241208039-6813-4-git-send-email-mchan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2009-05-06 16:40     ` Mike Christie
2009-05-06 16:42       ` Michael Chan
2009-06-08 17:56   ` James Bottomley
2009-06-08 17:59     ` Michael Chan [this message]
2009-06-08 18:13       ` James Bottomley
2009-06-08 18:07     ` Mike Christie
     [not found]       ` <4A2D5374.3030503-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
2009-06-08 20:07         ` Hans de Goede
2009-06-08 20:06           ` Michael Chan
2009-06-08 20:24           ` Mike Christie
2009-06-08 20:27             ` Hans de Goede
2009-05-01 20:00 ` [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver Michael Chan
2009-05-06 16:48   ` Mike Christie
2009-05-06 23:02     ` Karen Xie
2009-05-06 23:02       ` Karen Xie
2009-05-07 17:03     ` Michael Chan
2009-05-07 21:01       ` Mike Christie
2009-05-19  1:50         ` Michael Chan
2009-05-19 14:22           ` Mike Christie
2009-05-19 20:47             ` Michael Chan
2009-05-19 21:58               ` Mike Christie
2009-05-20 16:58                 ` Michael Chan
2009-05-20 19:57                   ` Mike Christie
     [not found]                     ` <4A14608F.6070800-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
2009-05-20 22:22                       ` Michael Chan
2009-05-20 22:51                         ` Mike Christie
  -- strict thread matches above, loose matches on Subject: below --
2009-04-24  0:22 [PATCH 0/4] Add bnx2 iSCSI support Michael Chan
2009-04-24  0:22 ` [PATCH 3/4] iscsi class, libiscsi: Add net config Michael Chan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1244483974.9184.404.camel@HP1 \
    --to=mchan@broadcom.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=davem@davemloft.net \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    --cc=netdev@vger.kernel.org \
    --cc=open-iscsi@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.