From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH 0/4] Re: Grub needs to check the programming interface for usb controllers
Date: Mon, 08 Jun 2009 16:30:59 -0400 [thread overview]
Message-ID: <1244493059.2536.16.camel@mj> (raw)
In-Reply-To: <20090608174515.881183682@gmail.com>
On Mon, 2009-06-08 at 18:45 +0100, oliver.henshaw@gmail.com wrote:
> Here's a second try. I used quilt to manage the patch series but
> mailed them by hand instead of exporting to a mailbox, and didn't
> realise that they weren't named as *.patch (otherwise I think the
> content type would have been fine). I should probably move on to git,
> but I was a little intimidated by the idea of re-writing history -
> manipulating a patch series seemed more natural to me. But onwards and
> upwards.
STGit manipulates the patches. It was inspired by quilt. It should be
really easy to learn for someone who knows git.
> I've removed all changes to trailing whitespace, as requested. There
> is still a whitespace change in side a comment, something I noticed
> with syntax highlighting.
I've applied your patches. The third patch in the series introduced a
compile warning due to iobase being a pointer on OHCI. I fixed that.
Please note that the ChangeLog is wrapped at the column 72. All
non-empty lines except the author's name start with one tab. Please
specify thew functions affected by your changes unless the changes are
in the top-level code or all over the place.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2009-06-08 20:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-07 18:27 Grub needs to check the programming interface for usb controllers Oliver Henshaw
2009-06-08 17:45 ` [PATCH 0/4] " oliver.henshaw
2009-06-08 17:45 ` [PATCH 1/4] Minor Cleanup oliver.henshaw
2009-06-08 17:45 ` [PATCH 2/4] Fix inteface definition for ohci oliver.henshaw
2009-06-08 17:45 ` [PATCH 3/4] Check usb programming interface oliver.henshaw
2009-06-08 17:45 ` [PATCH 4/4] Define fields in terms of the Class Code register oliver.henshaw
2009-06-08 20:30 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244493059.2536.16.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.