From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MDlo2-0005X4-7w for mharc-grub-devel@gnu.org; Mon, 08 Jun 2009 16:50:58 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MDlnz-0005WE-V2 for grub-devel@gnu.org; Mon, 08 Jun 2009 16:50:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MDlnv-0005U3-73 for grub-devel@gnu.org; Mon, 08 Jun 2009 16:50:55 -0400 Received: from [199.232.76.173] (port=46522 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MDlnu-0005Tz-U7 for grub-devel@gnu.org; Mon, 08 Jun 2009 16:50:50 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:57470) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MDlnu-0007qS-9G for grub-devel@gnu.org; Mon, 08 Jun 2009 16:50:50 -0400 Received: from [85.180.54.13] (e180054013.adsl.alicedsl.de [85.180.54.13]) by mrelayeu.kundenserver.de (node=mreu0) with ESMTP (Nemesis) id 0MKuxg-1MDlnr1oje-000cOr; Mon, 08 Jun 2009 22:50:47 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: References: <1244141869.3397.11.camel@fz.local> <1244149667.3397.12.camel@fz.local> Content-Type: text/plain Date: Mon, 08 Jun 2009 22:50:46 +0200 Message-Id: <1244494246.3833.33.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX195DuTq5RDbeyP0IZcRAVTK4IZTnetdDpXWv/s e0g42fY9JYWoX6ChnEhs8+IbKrQFfoBlKH2Uib8a49ZEHsjVMg 4cpjZhif4XLsL+cysv40A== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] add a --disk-module option to grub-install X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jun 2009 20:50:56 -0000 Am Freitag, den 05.06.2009, 23:26 +0200 schrieb Vladimir 'phcoder' Serbinenko: > - # generic method (used on coreboot) > + if [ "$disk_module" = ata ] ; then > + # generic method (used on coreboot and ata mod) > uuid="`$grub_probe --target=fs_uuid --device ${grub_device}`" > if [ "x${uuid}" = "x" ] ; then > - echo "UUID needed on this platform, but the filesystem > containing ${grubdir} does not support UUIDs." 1>&2 > + echo "UUID needed on this platform and with ata mod, but > the filesystem containing ${grubdir} does not support UUIDs." 1>&2 > IMO it would be better to remove "on this platform" part. > Otherwise patch looks ok, I will test it tomorrow Commited with it removed. > On Thu, Jun 4, 2009 at 11:07 PM, Felix Zielcke wrote: > > Am Donnerstag, den 04.06.2009, 20:57 +0200 schrieb Felix Zielcke: > >> Here's a patch which adds --disk-module to grub-install for i386-pc to > >> make it easier for users to try out ata mod instead of biosdisk. > > > > Args I forgot the actual parsing of the option. -- Felix Zielcke