From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MDmuo-0004BH-KX for mharc-grub-devel@gnu.org; Mon, 08 Jun 2009 18:02:02 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MDmum-000462-Sr for grub-devel@gnu.org; Mon, 08 Jun 2009 18:02:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MDmui-0003qy-3G for grub-devel@gnu.org; Mon, 08 Jun 2009 18:02:00 -0400 Received: from [199.232.76.173] (port=40061 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MDmui-0003qi-0v for grub-devel@gnu.org; Mon, 08 Jun 2009 18:01:56 -0400 Received: from c60.cesmail.net ([216.154.195.49]:25416) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MDmuh-0007eg-Gl for grub-devel@gnu.org; Mon, 08 Jun 2009 18:01:55 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 08 Jun 2009 18:01:55 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id E9C9634C6A for ; Mon, 8 Jun 2009 18:05:59 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <1241369732.4472.27.camel@ct> Content-Type: text/plain Date: Mon, 08 Jun 2009 18:01:53 -0400 Message-Id: <1244498513.25158.17.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] hfs+ uuid X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jun 2009 22:02:01 -0000 On Mon, 2009-06-08 at 22:50 +0200, Vladimir 'phcoder' Serbinenko wrote: > Here is the improved patch. I deliberately ignored md5 comments > because this part will be gone anyway whel Michael Gorven signs his > copyright assignment and we incorporate luks patches Please consider if it would be better to supply the filesystem UUID on the command line rather than the device name. That would make xnu_uuid leaner and more flexible. I think we need the "uuid" command that would get the uuid and the "xnu_uuid" command that would convert it. It would be great if you run xnu_uuid.c through indent. The coding style is quite different from that used elsewhere in GRUB. Or at least please strip trailing spaces. "file name required" is a wrong error message. It should be "device file required". I think it would be better to expand "fs" and "FS" in error messages as "filesystem". If the variable name is not specified, I think xnu_uuid should just output the UUID without any explanations. Explanations belong to the help, not to the normal output. "(void)mod;" is not needed. The "buf" variable in grub_cmd_xnu_uuid() is unused. -- Regards, Pavel Roskin