From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MDomf-0002l5-A4 for mharc-grub-devel@gnu.org; Mon, 08 Jun 2009 20:01:45 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MDomd-0002iX-Kx for grub-devel@gnu.org; Mon, 08 Jun 2009 20:01:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MDomY-0002gh-OB for grub-devel@gnu.org; Mon, 08 Jun 2009 20:01:43 -0400 Received: from [199.232.76.173] (port=37303 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MDomY-0002gd-Kr for grub-devel@gnu.org; Mon, 08 Jun 2009 20:01:38 -0400 Received: from c60.cesmail.net ([216.154.195.49]:43310) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MDomX-0004vE-SR for grub-devel@gnu.org; Mon, 08 Jun 2009 20:01:38 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 08 Jun 2009 20:01:28 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 7E11834C6A for ; Mon, 8 Jun 2009 20:05:38 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <6d6c12960906071137k6b66ec89iabd5efeb7aec8cb7@mail.gmail.com> Content-Type: text/plain Date: Mon, 08 Jun 2009 20:01:30 -0400 Message-Id: <1244505690.27232.3.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Link usb controller struct only when initialised X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2009 00:01:43 -0000 On Tue, 2009-06-09 at 01:57 +0200, Vladimir 'phcoder' Serbinenko wrote: > Commited with small stylistic change: comments start with an uppercase > letter and end with 2 spaces Thanks! By the way, it would be nice to rewrite uhci.c and ohci.c using GRUB lists (include/grub/list.h). And rewriting usb_keyboard.c would fix the crash when the USB keyboard is missing. -- Regards, Pavel Roskin