From: Artem Bityutskiy <dedekind@infradead.org>
To: Jehan Bing <jehan@orb.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [MTD-UTILS] Bad block handling in nandwrite when reading from standard input
Date: Tue, 09 Jun 2009 15:53:03 +0300 [thread overview]
Message-ID: <1244551983.5847.388.camel@localhost.localdomain> (raw)
In-Reply-To: <h0k3il$ij6$1@ger.gmane.org>
On Mon, 2009-06-08 at 15:32 -0700, Jehan Bing wrote:
> Nandwrite tries to use lseek() when failing to write on a page. lseek() will fail when used on the standard input so nandwrite fails. This code replaces lseek with a buffer.
>
> When the data is read, it is put in a buffer (filebuf). This buffer is reset at each block boundary. So a "seek" just means reading from the beginning of the buffer. writebuf and oobreadbuf are now just pointers to locations in filebuf.
>
> With this change, reading from stdin or from a file now uses the same code path.
>
>
> Signed-off-by: Jehan Bing <jehan@orb.com>
Too large patch for me to review. Could you split it on few smaller
ones please?
Also, please, do not send e-mails with
looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong
lines. Please, wrap them to 78 characters. You'll make it then
easier for other people to deal with you. Let's be nice.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2009-06-09 12:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 22:32 [PATCH] [MTD-UTILS] Bad block handling in nandwrite when reading from standard input Jehan Bing
2009-06-09 12:53 ` Artem Bityutskiy [this message]
2009-06-09 17:15 ` Jehan Bing
2009-06-09 23:04 ` [PATCH 1/3] [MTD-UTILS] Unified reading from standard input and from file Jehan Bing
2009-06-10 16:03 ` Artem Bityutskiy
2009-06-10 16:05 ` Artem Bityutskiy
2009-06-10 17:23 ` Jamie Lokier
2009-06-10 17:11 ` Jehan Bing
2009-06-11 7:32 ` Artem Bityutskiy
2009-06-11 17:43 ` [PATCH 1/3 v2] " Jehan Bing
2009-06-12 5:30 ` Artem Bityutskiy
2009-06-09 23:07 ` [PATCH 2/3] [MTD-UTILS] Use same kind of code for reading OOB than for regular data Nahor
2009-06-09 23:19 ` [PATCH 3/3] [MTD-UTILS] Handle bad block when reading from standard input Jehan Bing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244551983.5847.388.camel@localhost.localdomain \
--to=dedekind@infradead.org \
--cc=jehan@orb.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.