From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1ME6vO-0001zb-Ew for mharc-grub-devel@gnu.org; Tue, 09 Jun 2009 15:23:58 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ME6vM-0001z3-F8 for grub-devel@gnu.org; Tue, 09 Jun 2009 15:23:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ME6vI-0001x6-6o for grub-devel@gnu.org; Tue, 09 Jun 2009 15:23:56 -0400 Received: from [199.232.76.173] (port=53318 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ME6vH-0001x2-TQ for grub-devel@gnu.org; Tue, 09 Jun 2009 15:23:51 -0400 Received: from c60.cesmail.net ([216.154.195.49]:8663) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1ME6vH-0000IK-5V for grub-devel@gnu.org; Tue, 09 Jun 2009 15:23:51 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 09 Jun 2009 15:23:49 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id EA09634C6A for ; Tue, 9 Jun 2009 15:28:02 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: Content-Type: text/plain Date: Tue, 09 Jun 2009 15:23:48 -0400 Message-Id: <1244575428.4408.26.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] probe command X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2009 19:23:56 -0000 On Tue, 2009-06-09 at 20:23 +0200, Vladimir 'phcoder' Serbinenko wrote: > Following Pavel's suggestion to make uuid command I implemented probe > command similar to grub-probe Great! Please remove trailing whitespace. Please add missing space after "=" on line 64 in probe.c. The help doesn't look right (no space before "print filesystem module"). I can have a look how to fix it if you don't find a way. Actually, I would prefer separate options for targets, as in "search". That would be: -l --label -u --fs_uuid -p --partmap -d --driver (instead of "provider") --target=partmap doesn't work on whole disks. -- Regards, Pavel Roskin