Re: [Qemu-devel] [PATCH 0/7] virtio-net: Filter cleanup/improvements

[Mark McLoughlin <markmc@redhat.com>]

Hi Alex,

On Fri, 2009-06-05 at 14:46 -0600, Alex Williamson wrote:

> This series cleans up a few things around packet filtering.  I've probably
> gone a little overboard on breaking up patches, if we want to avoid bumping
> the save version_id so much, these could be mostly lumped together.  The
> main features here are more efficient handling of the filtering between
> unicast and multicast, better overflow tracking, adding more RX modes,
> and increasing the size of the filter table and control queue depth.
> 
> I took the reserved version_id 7 for vnet header support into consideration
> on the first patch.  I think we should be able to safely add the guts later
> with the placeholder.  If there are other RX mode controls we should add,
> let me know, now would be a good time to round out any other flags we can
> think of. 

The whole series looks good to me. Please make sure to send Rusty a
patch with the VIRTIO_NET_F_CTRL_RX_EXTRA etc. header additions.

The savevm version_id 9 bump is a little gratuitous, but I don't think
it's a big deal - I'd prefer to see cleanly separated patches like this,
and it wouldn't have been easy to e.g. split out the savevm changes into
a patch of their own at the end.

The vnet header version_id reservation is a good idea.

I've given this stuff some light testing, but would you care to outline
some instructions for some basic tests for as much as possible of this
stuff using a Linux guest? i.e. broadcast, multicast, promisc, mac
table, vlan table etc. - that's quite a set of tests you need to cover
all those cases.

Cheers,
Mark.