From: Mark McLoughlin <markmc@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix "defined but not used" warning
Date: Tue, 09 Jun 2009 22:53:05 +0100 [thread overview]
Message-ID: <1244584385.7164.22.camel@blaa> (raw)
In-Reply-To: <20090609182457.2d7a22dc@redhat.com>
On Tue, 2009-06-09 at 18:24 -0300, Luiz Capitulino wrote:
> The function qemu_calculate_timeout() is only used when CONFIG_IOTHREAD
> is not defined. When CONFIG_IOTHREAD is defined, we have the following
> warning:
>
> vl.c:4389: warning: ‘qemu_calculate_timeout’ defined but not used
>
> This change fixes that by moving the #ifdef/#endif from main_loop()
> into qemu_calculate_timeout(). This encapsulates the logic and allow
> us to use qemu_calculate_timeout() when CONFIG_IOTHREAD is defined
> or not (suggested by Glauber Costa).
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Looks correct and is a good cleanup too. Moves us closer to being able
to build with --enable-werror always :-)
Reviewed-by: Mark McLoughlin <markmc@redhat.com>
Cheers,
Mark.
next prev parent reply other threads:[~2009-06-09 21:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 21:24 [Qemu-devel] [PATCH] Fix "defined but not used" warning Luiz Capitulino
2009-06-09 21:53 ` Mark McLoughlin [this message]
2009-06-10 0:30 ` Marcelo Tosatti
2009-06-10 17:00 ` Blue Swirl
-- strict thread matches above, loose matches on Subject: below --
2009-06-04 18:29 [Qemu-devel] [PATCH]: " Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244584385.7164.22.camel@blaa \
--to=markmc@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.