From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MEUyp-0003fL-9C for mharc-grub-devel@gnu.org; Wed, 10 Jun 2009 17:05:07 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MEUym-0003dz-RA for grub-devel@gnu.org; Wed, 10 Jun 2009 17:05:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MEUyh-0003Y3-Pl for grub-devel@gnu.org; Wed, 10 Jun 2009 17:05:04 -0400 Received: from [199.232.76.173] (port=48420 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MEUyh-0003Xw-H2 for grub-devel@gnu.org; Wed, 10 Jun 2009 17:04:59 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:63026) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MEUyg-0007SE-3U for grub-devel@gnu.org; Wed, 10 Jun 2009 17:04:59 -0400 Received: from [85.180.31.40] (e180031040.adsl.alicedsl.de [85.180.31.40]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0MKv5w-1MEUyf0BwV-0001fU; Wed, 10 Jun 2009 23:04:57 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <1244339587.18630.8.camel@mj> References: <1244283931.3418.7.camel@fz.local> <1244339587.18630.8.camel@mj> Content-Type: text/plain Date: Wed, 10 Jun 2009 23:04:56 +0200 Message-Id: <1244667896.8525.17.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1+cC4XPRwuHELWkDf5hucs93d2q2BQX6dd8NYj 3+qOkEl2+kMC/4L0hZlcri/sZOyfu2zyOzDs+S+EFf5sisj1N+ JeQq1h+CXgPMmLG/6IYTA== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: 2273 lines in 170 files consists of only space and tabulators X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2009 21:05:05 -0000 Am Samstag, den 06.06.2009, 21:53 -0400 schrieb Pavel Roskin: > On Sat, 2009-06-06 at 12:25 +0200, Felix Zielcke wrote: > > fz@fz:~/grub/grub2.git$ rgrep -E "^[[:blank:]]+$" *|wc -l > > 2273 > > fz@fz:~/grub/grub2.git$ rgrep -E "^[[:blank:]]+$" *|sed -e 's/:.*//'|uniq|wc -l > > 170 > > > > Anyone wants me to do > > find . -type f -print0 | xargs -0 sed -i -r -e 's/^[[:blank:]]+$//' > > or does someone object? > > [:blank:] doestn't contain these ^L chars. > > > > By the way `git diff --color' shows if you introduce such a line with > > red, but strangely not when you remove one. > > Since we have linear development, it shouldn't be a problem for merging > patches. Besides, "patch" can be told to ignore whitespace differences. > > However, I would prefer that we remove all trailing whitespace, not just > that on empty lines. That is, remove "^" from the sed expression. Ok I just commited this. > As for the script, make sure that it's not run on any special files used > by Subversion or git. Maybe use DISTLIST. Thanks for the hint with DISTLIST. gendistlist.sh needed again an update. -- Felix Zielcke