Re: [PATCH v2 1/2] ASoC: change set_tdm_slot api to allow slot_size override.

From: Daniel Ribeiro <drwyrm@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Paul Shen <boshen9@gmail.com>,
	alsa-devel <alsa-devel@alsa-project.org>,
	Eric Miao <eric.y.miao@gmail.com>,
	Philipp Zabel <philipp.zabel@gmail.com>,
	linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>
Subject: Re: [PATCH v2 1/2] ASoC: change set_tdm_slot api to allow slot_size override.
Date: Thu, 11 Jun 2009 09:37:12 -0300	[thread overview]
Message-ID: <1244723832.21356.35.camel@brutus> (raw)
In-Reply-To: <20090611120738.GD26509@sirena.org.uk>

[-- Attachment #1.1: Type: text/plain, Size: 862 bytes --]

Em Qui, 2009-06-11 às 13:07 +0100, Mark Brown escreveu:
> On Thu, Jun 11, 2009 at 07:17:00AM -0300, Daniel Ribeiro wrote:
> > Extend set_tdm_slot to allow the user to arbitrarily set the frame width
> > and active TX/RX slots.
> 
> Looks good - I'll apply this unless someone else spots any issues.
> Unfortunately I'm not able to test the PXA changes right now.

Thanks!
Please note that this patch is useless without the next one (2/2), as
ssp_hw_params will not respect the slot_width set by set_tdm_slot().

> > Updates magician.c and wm9081.c for the new set_tdm_slot(). wm9081.c
> > still doesn't handle the slot_width override, I will submit this as a
> > separate patch after I figure how to handle the I2S case.
> 
> There's no need for you to spend time looking at this, I'll take care of
> it.

Ok, thanks!

-- 
Daniel Ribeiro

[-- Attachment #1.2: Esta é uma parte de mensagem assinada digitalmente --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel