From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MEo1z-0001zI-13 for mharc-grub-devel@gnu.org; Thu, 11 Jun 2009 13:25:39 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MEo1x-0001yb-01 for grub-devel@gnu.org; Thu, 11 Jun 2009 13:25:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MEo1s-0001wU-7W for grub-devel@gnu.org; Thu, 11 Jun 2009 13:25:36 -0400 Received: from [199.232.76.173] (port=37730 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MEo1r-0001wN-SE for grub-devel@gnu.org; Thu, 11 Jun 2009 13:25:31 -0400 Received: from c60.cesmail.net ([216.154.195.49]:10198) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MEo1r-0003vo-9W for grub-devel@gnu.org; Thu, 11 Jun 2009 13:25:31 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 11 Jun 2009 13:25:28 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 50E5F34C6A for ; Thu, 11 Jun 2009 13:29:59 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 Content-Type: text/plain Date: Thu, 11 Jun 2009 13:25:27 -0400 Message-Id: <1244741127.24612.19.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Warning free build achieved for most platforms X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2009 17:25:37 -0000 Hello! As of now, GRUB builds without warnings for all platforms except i386-coreboot. The build is done using gcc 4.4.0 for i386 and x86_64 and gcc 4.3.3 for PowerPC and SPARC64. Actually, the coreboot warnings should really be errors. In particular, kern/i386/coreboot/init.c calls grub_at_keyboard_init(), which is not defined anywhere. It looks like that the coreboot code needs to be ported to the new terminal handler code. Also, I noticed that escape sequences are not processed correctly in the serial code on i386-pc. The fix would be to wait a little bit after the input bytes arrive to see if they would make an escape sequence. The problem is still there, but I decided to fix the warning anyway to encourage warning-free code. If we want to use -Werror, now it's the time. In fact, it would be good for the coreboot code too, as its warnings are actually errors. -- Regards, Pavel Roskin