From: Markus Heidelberg <markus.heidelberg@web.de>
To: Marco Costalba <mcostalba@gmail.com>
Cc: git@vger.kernel.org, Markus Heidelberg <markus.heidelberg@web.de>
Subject: [PATCH QGit RFC] Fix "Save patch..." on a commit range
Date: Sat, 13 Jun 2009 01:29:17 +0200 [thread overview]
Message-ID: <1244849357-31166-1-git-send-email-markus.heidelberg@web.de> (raw)
Creating a patch series didn't work, because the SHA1 list was
interpreted in the wrong order.
Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
---
To find out if this problem was caused by a regression, I tested
2e63608 (Format patch: use selected patches as a range, 2008-01-13),
which changed the behavior of generating multiple patches and introduced
the lines that are now changed in my patch.
But that commit didn't work for me either. Now I don't think that it
didn't work for you at that time. Can this be a Qt problem?
src/git.cpp | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/git.cpp b/src/git.cpp
index a20bf0d..0f18f61 100644
--- a/src/git.cpp
+++ b/src/git.cpp
@@ -1577,9 +1577,9 @@ bool Git::formatPatch(SCList shaList, SCRef dirPath, SCRef remoteDir) {
if (remote)
workDir = remoteDir; // run() uses workDir value
- // shaList is ordered by newest to oldest
- runCmd.append(" " + shaList.last());
- runCmd.append(QString::fromLatin1("^..") + shaList.first());
+ // shaList is ordered by oldest to newest
+ runCmd.append(" " + shaList.first());
+ runCmd.append(QString::fromLatin1("^..") + shaList.last());
bool ret = run(runCmd);
workDir = tmp;
return ret;
--
1.6.3.2.248.g8cb59
next reply other threads:[~2009-06-12 23:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 23:29 Markus Heidelberg [this message]
2009-06-13 7:13 ` [PATCH QGit RFC] Fix "Save patch..." on a commit range Marco Costalba
2009-06-13 10:11 ` Markus Heidelberg
2009-06-13 11:02 ` Markus Heidelberg
2009-06-13 11:12 ` Marco Costalba
2009-06-13 11:33 ` Markus Heidelberg
2009-06-13 12:23 ` Marco Costalba
2009-06-15 21:13 ` Markus Heidelberg
2009-06-15 21:25 ` Marco Costalba
2009-06-15 21:45 ` Marco Costalba
2009-06-15 22:07 ` Marco Costalba
2009-06-15 23:53 ` Markus Heidelberg
2009-06-16 6:10 ` Marco Costalba
2009-06-16 18:48 ` Markus Heidelberg
2009-06-15 23:44 ` Markus Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244849357-31166-1-git-send-email-markus.heidelberg@web.de \
--to=markus.heidelberg@web.de \
--cc=git@vger.kernel.org \
--cc=mcostalba@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.