From: "Michael Chan" <mchan@broadcom.com>
To: Paul Mundt <lethal@linux-sh.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH] scsi: bnx2i depends on PCI.
Date: Mon, 15 Jun 2009 11:23:00 -0700 [thread overview]
Message-ID: <1245090180.12000.16.camel@HP1> (raw)
In-Reply-To: <20090615181123.GB30693@linux-sh.org>
On Mon, 2009-06-15 at 11:11 -0700, Paul Mundt wrote:
> This fixes up the CONFIG_PCI=n case, primarily triggered on
> allmodconfig/allyesconfig builds:
>
> drivers/scsi/bnx2i/bnx2i_iscsi.c:760: error: implicit declaration of function 'pci_dev_get'
> make[4]: *** [drivers/scsi/bnx2i/bnx2i_iscsi.o] Error 1
> make[3]: *** [drivers/scsi/bnx2i] Error 2
>
> The entire driver is PCI dependent, so just reflect it in the Kconfig.
>
A similar patch is already in James' tree:
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=babdb788f7ec1a782a52240a5f6dae568f32565f
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
> Cc: Michael Chan <mchan@broadcom.com>
>
> ---
>
> drivers/scsi/bnx2i/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/bnx2i/Kconfig b/drivers/scsi/bnx2i/Kconfig
> index 820d428..0d63146 100644
> --- a/drivers/scsi/bnx2i/Kconfig
> +++ b/drivers/scsi/bnx2i/Kconfig
> @@ -1,5 +1,6 @@
> config SCSI_BNX2_ISCSI
> tristate "Broadcom NetXtreme II iSCSI support"
> + depends on PCI
> select SCSI_ISCSI_ATTRS
> select CNIC
> ---help---
>
prev parent reply other threads:[~2009-06-15 18:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 18:11 [PATCH] scsi: bnx2i depends on PCI Paul Mundt
2009-06-15 18:23 ` Michael Chan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245090180.12000.16.camel@HP1 \
--to=mchan@broadcom.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=lethal@linux-sh.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.