From: "Michael Chan" <mchan@broadcom.com>
To: "Paul Mundt" <lethal@linux-sh.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: CNIC depends on PCI.
Date: Mon, 15 Jun 2009 11:24:58 -0700 [thread overview]
Message-ID: <1245090298.12000.17.camel@HP1> (raw)
In-Reply-To: <20090615181244.GC30693@linux-sh.org>
On Mon, 2009-06-15 at 11:12 -0700, Paul Mundt wrote:
> Even though this driver does shifty things with UIO to make it less
> obvious, it is still PCI dependent:
>
> drivers/net/cnic.c:2395: error: implicit declaration of function 'pci_dev_get'
> make[3]: *** [drivers/net/cnic.o] Error 1
> make[2]: *** [drivers/net] Error 2
>
> This fixes up the CONFIG_PCI=n case, primarily triggered on
> allmodconfig/allyesconfig builds:
>
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
> Cc: Michael Chan <mchan@broadcom.com>
A similar patch is already in James' tree:
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=babdb788f7ec1a782a52240a5f6dae568f32565f
>
> ---
>
> drivers/net/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 3b63831..f6d6888 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2272,8 +2272,7 @@ config BNX2
>
> config CNIC
> tristate "Broadcom CNIC support"
> - depends on BNX2
> - depends on UIO
> + depends on PCI && BNX2 && UIO
> help
> This driver supports offload features of Broadcom NetXtremeII
> gigabit Ethernet cards.
>
prev parent reply other threads:[~2009-06-15 18:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 18:12 [PATCH] net: CNIC depends on PCI Paul Mundt
2009-06-15 18:24 ` Michael Chan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245090298.12000.17.camel@HP1 \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=lethal@linux-sh.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.