From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MGNTq-000175-A8 for mharc-grub-devel@gnu.org; Mon, 15 Jun 2009 21:28:54 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MGNTp-000170-5t for grub-devel@gnu.org; Mon, 15 Jun 2009 21:28:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MGNTj-00016o-RI for grub-devel@gnu.org; Mon, 15 Jun 2009 21:28:51 -0400 Received: from [199.232.76.173] (port=55759 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MGNTj-00016l-Ln for grub-devel@gnu.org; Mon, 15 Jun 2009 21:28:47 -0400 Received: from c60.cesmail.net ([216.154.195.49]:57489) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MGNTj-00015h-3W for grub-devel@gnu.org; Mon, 15 Jun 2009 21:28:47 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 15 Jun 2009 21:28:45 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 7380D34C6D for ; Mon, 15 Jun 2009 21:33:54 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: Content-Type: text/plain Date: Mon, 15 Jun 2009 21:28:43 -0400 Message-Id: <1245115723.27324.34.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH 6/18] define asm constant for absolute memory access X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2009 01:28:53 -0000 On Sat, 2009-05-30 at 16:46 +0200, Vladimir 'phcoder' Serbinenko wrote: > +#ifdef APPLE_CC > +#define MSG(x) x ## _abs = ABS(x); movw $x ## _abs, %si; call message > +#else > #define MSG(x) movw $ABS(x), %si; call message > +#endif I have verified that defining APPLE_CC on Fedora would produce exactly the same bytecode. I don't see any reason to have preprocessor conditionals all over the place. Are you trying to support as without variables? > +#ifdef APPLE_CC > + movl $(mmaphook_mmap_rel), %esi > +#else > movw $(DS(mmaphook_mmap)), %si > +#endif That's not an equivalent replacement. The argument width is different. -- Regards, Pavel Roskin