From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: type bounds audit messages From: Eric Paris To: Steve Grubb Cc: KaiGai Kohei , Stephen Smalley , James Morris , selinux@tycho.nsa.gov, Eamon Walsh , jdennis@redhat.com In-Reply-To: <200906161123.52932.sgrubb@redhat.com> References: <1244730288.10762.120.camel@localhost.localdomain> <200906161040.52279.sgrubb@redhat.com> <1245164133.2848.12.camel@localhost.localdomain> <200906161123.52932.sgrubb@redhat.com> Content-Type: text/plain Date: Tue, 16 Jun 2009 11:41:09 -0400 Message-Id: <1245166869.2848.21.camel@localhost.localdomain> Mime-Version: 1.0 Sender: owner-selinux@tycho.nsa.gov List-Id: selinux@tycho.nsa.gov On Tue, 2009-06-16 at 11:23 -0400, Steve Grubb wrote: > On Tuesday 16 June 2009 10:55:33 am Eric Paris wrote: > > > > I feel good for all but the { setattr write } > > > > > > > > It's a new message, we have no parsers which need the old format, how > > > > would others feel about > > > > > > > > perm="setattr,write" ? > > > > > > I'd recommend losing the quotes. I think you are doing this because of > > > untrusted_string, but I doubt the user can influence this. > > > > I'm starting to buy into the 'quotes makes it easy to know it's a > > string' argument from jdennis. > > Any field that has a value starting and ending with quotes means that its > encoded due to untrusted users having influence over it. That is the parsing > rule. Maybe you meant to say that any field starting with a quote is a string that COULD have been encoded but wasn't because it was found to contain a safe valid string. I don't see how this hurts those rules. Like I said I'm ok with dropping the "" but I think it is a lot easier on the parser to put " around strings to make them easier to recognize.... -Eric -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes as the message.