All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Smalley <sds@tycho.nsa.gov>
To: Jason Johnson <jason.johnson.081@gmail.com>
Cc: KaiGai Kohei <kaigai@ak.jp.nec.com>, SE-Linux <selinux@tycho.nsa.gov>
Subject: Re: Possible bug with fd class?
Date: Wed, 17 Jun 2009 08:26:53 -0400	[thread overview]
Message-ID: <1245241613.29288.1.camel@localhost.localdomain> (raw)
In-Reply-To: <aa22f0200906161413j5c9ffc8eo60ae175b3c8dd16@mail.gmail.com>

On Tue, 2009-06-16 at 23:13 +0200, Jason Johnson wrote:
> On Tue, Jun 16, 2009 at 10:01 PM, Stephen Smalley<sds@tycho.nsa.gov> wrote:
> >
> > In this particular case it doesn't appear to be a problem, but often
> > programs unwittingly leak file descriptors when they exec a child
> > program.  Thus, this permission check has often been helpful in catching
> > such unintentional leaks, which can ultimately prove to be
> > security-relevant (leaking access to some resource that shouldn't be
> > accessible to the new program).
> >
> > There are two checks applied:
> > - the fd use check, which controls whether a process can use a
> > descriptor originally opened by a process in a different security
> > context, and
> > - the file read/write/append checks, which control whether the process
> > can access the file in accordance with the open file flags.
> >
> > If either set of checks fails, then the descriptor is closed and
> > replaced with a reference to the null device (to avoid application
> > misbehavior).
> >
> > Naturally, if the passing of the descriptor is intentional and valid,
> > you can allow it in policy.
> 
> So are you saying that this /dev/null access by syslog-ng is actually
> because some other access actually failed?

No, that would show up as a separate AVC, and would
reference /selinux/null rather than /dev/null.

> I don't see how this could be either:
> 
> # semanage fcontext -l|grep logrotate
> /etc/cron\.(daily|weekly)/sysklogd                 regular file
> system_u:object_r:logrotate_exec_t:s0
> /var/lib/logrotate(/.*)?                           all files
> system_u:object_r:logrotate_var_lib_t:s0
> /usr/sbin/logrotate                                regular file
> system_u:object_r:logrotate_exec_t:s0
> 
> Note that the odd sysklogd entry doesn't exist in either of those two
> directories.

Some entries in file_contexts are for other distributions and may not
apply to your particular filesystem.  That's ok - it doesn't do any
harm.

-- 
Stephen Smalley
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

  reply	other threads:[~2009-06-17 12:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16  4:48 Possible bug with fd class? Jason Johnson
2009-06-16  5:18 ` KaiGai Kohei
2009-06-16 17:31   ` Jason Johnson
2009-06-16 20:01     ` Stephen Smalley
2009-06-16 21:13       ` Jason Johnson
2009-06-17 12:26         ` Stephen Smalley [this message]
2009-06-17 18:28           ` Jason Johnson
2009-06-17 19:13             ` Stephen Smalley
2009-06-17 19:17               ` Stephen Smalley
     [not found]               ` <aa22f0200906172153n2c67abcj1309a76208c5b96e@mail.gmail.com>
2009-06-18 12:48                 ` Stephen Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1245241613.29288.1.camel@localhost.localdomain \
    --to=sds@tycho.nsa.gov \
    --cc=jason.johnson.081@gmail.com \
    --cc=kaigai@ak.jp.nec.com \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.