From: David Howells <dhowells@redhat.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: fscache: bug report: dereferencing before checking
Date: Mon, 22 Mar 2010 12:47:17 +0000 [thread overview]
Message-ID: <12453.1269262037@redhat.com> (raw)
In-Reply-To: <20100322120753.GE21571@bicker>
Dan Carpenter <error27@gmail.com> wrote:
> Can "page" be NULL here?
Hmmm... Interesting question. I'm not sure it can be NULL.
radix_tree_gang_lookup_tag() finds pages in the tree that have a particular
tag set, and returns the number of pages it has selected. If that number is
!= 1, then I don't proceed with accessing the array.
So I think the tests of page later are unnecessary.
David
prev parent reply other threads:[~2010-03-22 12:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 12:07 fscache: bug report: dereferencing before checking Dan Carpenter
2010-03-22 12:47 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12453.1269262037@redhat.com \
--to=dhowells@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.