From: Steven Rostedt <srostedt@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
linux-arch@vger.kernel.org, mingo@elte.hu, kyle@mcmartin.ca,
cl@linux-foundation.org, Jesper.Nilsson@axis.com,
benh@kernel.crashing.org, paulmck@linux.vnet.ibm.com,
David Howells <dhowells@redhat.com>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
arm@redhat.com
Subject: Re: [PATCH 6/9 UPDATED] percpu: enforce global definition
Date: Thu, 18 Jun 2009 09:26:37 -0400 [thread overview]
Message-ID: <1245331597.5195.8.camel@localhost.localdomain> (raw)
In-Reply-To: <4A39EF13.7010309@kernel.org>
On Thu, 2009-06-18 at 16:38 +0900, Tejun Heo wrote:
> Some archs (alpha and s390) need to add 'weak' attribute to percpu
> variable definitions so that the compiler generates external
> references for them. To allow this, enforce global definition of all
> percpu variables.
>
> This patch makes DEFINE_PER_CPU_SECTION() do DECLARE_PERCPU_SECTION()
> implicitly and drop static from all percpu definitions.
>
> [ Impact: all percpu variables are forced to be global ]
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reviewed-by: Christoph Lameter <cl@linux-foundation.org>
> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Uh, wont this cause name space collisions?
-- Steve
next prev parent reply other threads:[~2009-06-18 13:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 3:40 [GIT PATCH core/percpu] percpu: convert most archs to dynamic percpu, take#3 Tejun Heo
2009-06-17 3:40 ` Tejun Heo
2009-06-17 3:40 ` [PATCH 1/9] percpu: fix too lazy vunmap cache flushing Tejun Heo
2009-06-17 3:40 ` Tejun Heo
2009-06-17 3:40 ` [PATCH 2/9] percpu: use dynamic percpu allocator as the default percpu allocator Tejun Heo
2009-06-17 3:40 ` Tejun Heo
2009-06-17 12:40 ` James Bottomley
2009-06-17 13:15 ` Tejun Heo
2009-06-17 13:32 ` Kyle McMartin
2009-06-17 3:40 ` [PATCH 3/9] CRIS: Change DEFINE_PER_CPU of current_pgd to be non volatile Tejun Heo
2009-06-17 3:40 ` Tejun Heo
2009-06-18 7:27 ` [UPDATED PATCH " Tejun Heo
2009-06-18 7:27 ` Tejun Heo
2009-06-17 3:40 ` [PATCH 4/9] percpu: cleanup percpu array definitions Tejun Heo
2009-06-17 3:40 ` Tejun Heo
2009-06-17 3:40 ` Tejun Heo
2009-06-17 16:57 ` Christoph Lameter
2009-06-17 16:57 ` Christoph Lameter
2009-06-17 3:40 ` [PATCH 5/9] percpu: clean up percpu variable definitions Tejun Heo
2009-06-17 3:40 ` Tejun Heo
2009-06-17 3:40 ` Tejun Heo
2009-06-17 17:00 ` Christoph Lameter
2009-06-17 17:00 ` Christoph Lameter
2009-06-18 7:36 ` [PATCH 5/9 UPDATED] " Tejun Heo
2009-06-18 7:36 ` Tejun Heo
2009-06-18 7:36 ` Tejun Heo
2009-06-17 3:40 ` [PATCH 7/9] alpha: kill unnecessary __used attribute in PER_CPU_ATTRIBUTES Tejun Heo
2009-06-17 3:40 ` Tejun Heo
2009-06-17 3:40 ` [PATCH 8/9] alpha: switch to dynamic percpu allocator Tejun Heo
2009-06-17 3:40 ` Tejun Heo
2009-06-17 3:41 ` [PATCH 9/9] s390: " Tejun Heo
2009-06-17 3:41 ` Tejun Heo
[not found] ` <1245210060-24344-7-git-send-email-tj@kernel.org>
[not found] ` <4A39EF13.7010309@kernel.org>
2009-06-18 13:26 ` Steven Rostedt [this message]
2009-06-18 13:51 ` [PATCH 6/9 UPDATED] percpu: enforce global definition Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245331597.5195.8.camel@localhost.localdomain \
--to=srostedt@redhat.com \
--cc=Jesper.Nilsson@axis.com \
--cc=arm@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=cl@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ink@jurassic.park.msu.ru \
--cc=kyle@mcmartin.ca \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.