From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MHftp-0007pl-JP for mharc-grub-devel@gnu.org; Fri, 19 Jun 2009 11:21:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MHfto-0007og-42 for grub-devel@gnu.org; Fri, 19 Jun 2009 11:21:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MHftj-0007mD-Fi for grub-devel@gnu.org; Fri, 19 Jun 2009 11:21:03 -0400 Received: from [199.232.76.173] (port=46804 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MHftj-0007mA-42 for grub-devel@gnu.org; Fri, 19 Jun 2009 11:20:59 -0400 Received: from c60.cesmail.net ([216.154.195.49]:36521) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MHfti-0002aK-N6 for grub-devel@gnu.org; Fri, 19 Jun 2009 11:20:59 -0400 Received: from unknown (HELO smtprelay1.cesmail.net) ([192.168.1.111]) by c60.cesmail.net with ESMTP; 19 Jun 2009 11:20:54 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay1.cesmail.net (Postfix) with ESMTPSA id 23FB034C69 for ; Fri, 19 Jun 2009 11:20:53 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: Content-Type: text/plain Date: Fri, 19 Jun 2009 11:20:52 -0400 Message-Id: <1245424852.3431.30.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] fix SigSegV and hang with grub-emu-usb X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2009 15:21:04 -0000 On Fri, 2009-06-19 at 16:58 +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello when testing grub-emu with USB support I stumbled across several problems > 1) compile time warning of undefined grub_usb_libinit > 2) When launched under normal user it crashed > 3) When launched as superuser it hanged on ls > Here is the fix. Formatting omitted for readability It's not clear which changes are responsible for fixing which problems. Please post separate patches if you want a meaningful review. Regarding the compile warning fix, I would try to make grub_libusb_init() and grub_libusb_fini() appear in grub_emu_init.h rather than declare them elsewhere. -- Regards, Pavel Roskin