From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MHgID-0003D2-C6 for mharc-grub-devel@gnu.org; Fri, 19 Jun 2009 11:46:17 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MHgIB-0003CI-9o for grub-devel@gnu.org; Fri, 19 Jun 2009 11:46:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MHgI5-0003B9-Th for grub-devel@gnu.org; Fri, 19 Jun 2009 11:46:14 -0400 Received: from [199.232.76.173] (port=55287 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MHgI5-0003B6-OI for grub-devel@gnu.org; Fri, 19 Jun 2009 11:46:09 -0400 Received: from c60.cesmail.net ([216.154.195.49]:2588) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MHgI5-0007Bp-8i for grub-devel@gnu.org; Fri, 19 Jun 2009 11:46:09 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 19 Jun 2009 11:46:08 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 5735734C6A for ; Fri, 19 Jun 2009 11:51:49 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: Content-Type: text/plain Date: Fri, 19 Jun 2009 11:46:06 -0400 Message-Id: <1245426366.2820.2.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] fix building bug with --enable-grub-emu-usb X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2009 15:46:15 -0000 On Wed, 2009-06-17 at 15:27 +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello. This is a fix for problem in subject line. I believe this fix > to be correct and legitimate but as I don't know ruby well could > someone review it? If nobody knows ruby in depth I think we can commit > this even without deep review I would prefer that we take a different approach with grub-emu. I think the USB support should be enabled whenever libusb is enabled. If libusb is missing, then the USB related code should be omitted from the sources using preprocessor directives. The build system doesn't need to know anything about it. Generally, please think how to reduce complexity, not how to add to it. Complex systems are harder to maintain. -- Regards, Pavel Roskin