From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MHgkd-0002Es-Uf for mharc-grub-devel@gnu.org; Fri, 19 Jun 2009 12:15:39 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MHgkc-0002EZ-Bs for grub-devel@gnu.org; Fri, 19 Jun 2009 12:15:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MHgkX-00029S-RJ for grub-devel@gnu.org; Fri, 19 Jun 2009 12:15:38 -0400 Received: from [199.232.76.173] (port=45933 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MHgkX-00029C-Kt for grub-devel@gnu.org; Fri, 19 Jun 2009 12:15:33 -0400 Received: from c60.cesmail.net ([216.154.195.49]:35773) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MHgkX-0004PX-4g for grub-devel@gnu.org; Fri, 19 Jun 2009 12:15:33 -0400 Received: from unknown (HELO smtprelay1.cesmail.net) ([192.168.1.111]) by c60.cesmail.net with ESMTP; 19 Jun 2009 12:15:31 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay1.cesmail.net (Postfix) with ESMTPSA id B51E434C69 for ; Fri, 19 Jun 2009 12:15:30 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <48f46e890906182308i67d33260w7e5c6ea71ab3c44c@mail.gmail.com> Content-Type: text/plain Date: Fri, 19 Jun 2009 12:15:29 -0400 Message-Id: <1245428129.2820.20.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] bless command X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2009 16:15:38 -0000 On Fri, 2009-06-19 at 13:53 +0200, Vladimir 'phcoder' Serbinenko wrote: > Attached to this e-mail and on my personal git repository in branch > bless the rediff. I was thinking of adding ppc mac support but haven't > done it yet I think we can incorporate apple intel support without the > ppc counterpart yet. Does anyone object? I don't see how PowerPC support would be different. It's a filesystem issue. Actually, on PowerPC blessing on HFS (not on HFS+) would be needed. I think it would be better to name the command "hfsbless". The way, HFS support could be added to the same command later. Adding commands/hfspbless.c to grub_emu_SOURCES only on i386-pc seems inconsistent. Either it should be added everywhere or nowhere. I think we need a build system reorganization to allow grub_emu_SOURCES to be mostly platform independent. The spacing change in conf/i386-pc.rmk is unnecessary. "(void) mod;" is unnecessary. fs/hfsplus.c should include grub/hfsplus.h or it won't compile. In find_inode(), the core start with if(! info->inodeset) return 0; It's both faster and more readable. Please run hfspbless.c through indent. It would fix such things as (fs->dir) (dev, *path == 0 ?"/":path, find_inode); -- Regards, Pavel Roskin